New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RPC: Hide softfork if timeout is 0 #8258

Merged
merged 1 commit into from Jun 27, 2016

Conversation

Projects
None yet
6 participants
@jl2012
Member

jl2012 commented Jun 24, 2016

Replace #8209

getblockchaininfo will not show a BIP9 proposal if the timeout is 0. A timeout before the genesis block timestamp guarantees that a softfork must not be activated in any circumstances. A timeout of 0 should be used when we want to merge a softfork proposal without defining its deployment schedule

@paveljanik

This comment has been minimized.

Show comment
Hide comment
@paveljanik

paveljanik Jun 24, 2016

Contributor

ACK 409f833

Without this change, the current master shows (RPC getblockchaininfo):

    "segwit": {
      "status": "failed",
      "startTime": 0,
      "timeout": 0
    }
Contributor

paveljanik commented Jun 24, 2016

ACK 409f833

Without this change, the current master shows (RPC getblockchaininfo):

    "segwit": {
      "status": "failed",
      "startTime": 0,
      "timeout": 0
    }
@sipa

This comment has been minimized.

Show comment
Hide comment
@sipa

sipa Jun 24, 2016

Member
Member

sipa commented Jun 24, 2016

@MarcoFalke MarcoFalke added this to the 0.13.0 milestone Jun 25, 2016

@dcousens

This comment has been minimized.

Show comment
Hide comment
@dcousens

dcousens Jun 27, 2016

Contributor

ACK 409f833

Contributor

dcousens commented Jun 27, 2016

ACK 409f833

@laanwj laanwj merged commit 409f833 into bitcoin:master Jun 27, 2016

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

laanwj added a commit that referenced this pull request Jun 27, 2016

Merge #8258: RPC: Hide softfork if timeout is 0
409f833 RPC: Hide softfork if timeout is 0 (jl2012)
@laanwj

This comment has been minimized.

Show comment
Hide comment
@laanwj

laanwj Jun 28, 2016

Member

This needs backport to 0.12, but will only merge cleanly after segwit.

Member

laanwj commented Jun 28, 2016

This needs backport to 0.12, but will only merge cleanly after segwit.

@jl2012

This comment has been minimized.

Show comment
Hide comment
@jl2012

jl2012 Jun 28, 2016

Member

@laanwj I don't think a backport is needed since we won't release a backport with undefined softfork

Member

jl2012 commented Jun 28, 2016

@laanwj I don't think a backport is needed since we won't release a backport with undefined softfork

@laanwj

This comment has been minimized.

Show comment
Hide comment
@laanwj

laanwj Jun 29, 2016

Member

OK

Member

laanwj commented Jun 29, 2016

OK

@laanwj laanwj removed the Needs backport label Jun 29, 2016

codablock added a commit to codablock/dash that referenced this pull request Sep 19, 2017

Merge #8258: RPC: Hide softfork if timeout is 0
409f833 RPC: Hide softfork if timeout is 0 (jl2012)

codablock added a commit to codablock/dash that referenced this pull request Dec 27, 2017

Merge #8258: RPC: Hide softfork if timeout is 0
409f833 RPC: Hide softfork if timeout is 0 (jl2012)

codablock added a commit to codablock/dash that referenced this pull request Dec 28, 2017

Merge #8258: RPC: Hide softfork if timeout is 0
409f833 RPC: Hide softfork if timeout is 0 (jl2012)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment