New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

qt: Network-specific example address #8288

Merged
merged 1 commit into from Jul 6, 2016

Conversation

Projects
None yet
5 participants
@laanwj
Member

laanwj commented Jun 29, 2016

Generate an example address (with invalid CRC) for in the bitcoin address widgets, based on the network prefix, instead of hardcoding a mainnet address.

Generates:

  • 1NS17iag9jJgTHD1VXjvLCEnZuQ3rJDE9L for mainnet (same as now)
  • n2wxQmfexkjwEPgdD6iJA7T7RtzkmHxhFc for testnet

Later on we may get rid of the example address completely, but that's too late for 0.13, as removing e.g. %1 would change a translation string.

@laanwj laanwj added the GUI label Jun 29, 2016

qt: Network-specific example address
Generate an (invalid) example address for in the bitcoin address
widgets, based on the network prefix, instead of hardcoding a mainnet
address.

- `1NS17iag9jJgTHD1VXjvLCEnZuQ3rJDE9L` for mainnet (same as now)
- `n2wxQmfexkjwEPgdD6iJA7T7RtzkmHxhFc` for testnet
@MarcoFalke

This comment has been minimized.

Show comment
Hide comment
@MarcoFalke
Member

MarcoFalke commented Jun 29, 2016

utACK 4f44cb6

@paveljanik

This comment has been minimized.

Show comment
Hide comment
@paveljanik

paveljanik Jun 29, 2016

Contributor

ACK 4f44cb6

Contributor

paveljanik commented Jun 29, 2016

ACK 4f44cb6

@jonasschnelli

This comment has been minimized.

Show comment
Hide comment
@jonasschnelli

jonasschnelli Jun 29, 2016

Member

Yes. Why not.

utACK 4f44cb6

Member

jonasschnelli commented Jun 29, 2016

Yes. Why not.

utACK 4f44cb6

@MarcoFalke MarcoFalke added this to the 0.13.0 milestone Jun 29, 2016

@fanquake

This comment has been minimized.

Show comment
Hide comment
@fanquake

fanquake Jul 5, 2016

Member

ACK 4f44cb6

Mainnet
mainnet
Testnet
testnet

Member

fanquake commented Jul 5, 2016

ACK 4f44cb6

Mainnet
mainnet
Testnet
testnet

@@ -107,6 +107,23 @@ QFont fixedPitchFont()
#endif
}
// Just some dummy data to generate an convincing random-looking (but consistent) address

This comment has been minimized.

@fanquake

fanquake Jul 5, 2016

Member

nit s/an/a

@fanquake

fanquake Jul 5, 2016

Member

nit s/an/a

@jonasschnelli jonasschnelli merged commit 4f44cb6 into bitcoin:master Jul 6, 2016

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

jonasschnelli added a commit that referenced this pull request Jul 6, 2016

Merge #8288: qt: Network-specific example address
4f44cb6 qt: Network-specific example address (Wladimir J. van der Laan)

codablock added a commit to codablock/dash that referenced this pull request Sep 19, 2017

Merge #8288: qt: Network-specific example address
4f44cb6 qt: Network-specific example address (Wladimir J. van der Laan)

codablock added a commit to codablock/dash that referenced this pull request Dec 27, 2017

Merge #8288: qt: Network-specific example address
4f44cb6 qt: Network-specific example address (Wladimir J. van der Laan)

codablock added a commit to codablock/dash that referenced this pull request Dec 28, 2017

Merge #8288: qt: Network-specific example address
4f44cb6 qt: Network-specific example address (Wladimir J. van der Laan)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment