Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Bugfix: Allow building libbitcoinconsensus without any univalue #8293

Merged
merged 1 commit into from Aug 13, 2016

Conversation

Projects
None yet
4 participants
Member

luke-jr commented Jun 30, 2016

No description provided.

Member

theuni commented Jun 30, 2016

Concept ACK. A few nits:

  • Please store the test as build_no_programs or build_libs_only or so, so that we only need the ugly xnononono stuff in one place.
  • I'd rather not abuse system_univalue that way, as it's not obvious what it's doing. Please change that to configure_embedded_univalue or so, and rework the test as necessary.

@laanwj laanwj added the Build system label Jun 30, 2016

Member

luke-jr commented Jun 30, 2016

It's conceivable that at some point bitcoin-tx could be freed of the univalue dependency as well, so I'm not sure it makes sense to do the dedicated var?

Owner

laanwj commented Jul 1, 2016

I don't think that's realistic. bitcoin-tx uses JSON objects in various places in the interface

Member

theuni commented Jul 6, 2016

@luke-jr My only concern is that "system_univalue" should not be equated to "don't use any univalue". renaming to need_univalue would suffice.

Owner

laanwj commented Aug 3, 2016

Ok, let's rename it then.

Member

luke-jr commented Aug 9, 2016

Renamed.

Member

theuni commented Aug 12, 2016

Thanks. utACK.

@laanwj laanwj merged commit 8a270b2 into bitcoin:master Aug 13, 2016

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

laanwj added a commit that referenced this pull request Aug 13, 2016

Merge #8293: Bugfix: Allow building libbitcoinconsensus without any u…
…nivalue


8a270b2 Bugfix: Allow building libbitcoinconsensus without any univalue (Luke Dashjr)
Contributor

jgarzik commented Aug 13, 2016

ut ACK

Member

luke-jr commented Sep 10, 2016

Needs backport to 0.13.

luke-jr added a commit to luke-jr/bitcoin that referenced this pull request Sep 21, 2016

codablock added a commit to codablock/dash that referenced this pull request Sep 19, 2017

Merge #8293: Bugfix: Allow building libbitcoinconsensus without any u…
…nivalue


8a270b2 Bugfix: Allow building libbitcoinconsensus without any univalue (Luke Dashjr)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment