-
Notifications
You must be signed in to change notification settings - Fork 36.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bugfix: Allow building libbitcoinconsensus without any univalue #8293
Conversation
Concept ACK. A few nits:
|
It's conceivable that at some point bitcoin-tx could be freed of the univalue dependency as well, so I'm not sure it makes sense to do the dedicated var? |
I don't think that's realistic. bitcoin-tx uses JSON objects in various places in the interface |
@luke-jr My only concern is that "system_univalue" should not be equated to "don't use any univalue". renaming to need_univalue would suffice. |
Ok, let's rename it then. |
d0c8332
to
f22e2a3
Compare
Renamed. |
f22e2a3
to
8a270b2
Compare
Thanks. utACK. |
…nivalue 8a270b2 Bugfix: Allow building libbitcoinconsensus without any univalue (Luke Dashjr)
ut ACK |
Needs backport to 0.13. |
Github-Pull: bitcoin#8293 Rebased-From: 8a270b2
…t any univalue 8a270b2 Bugfix: Allow building libbitcoinconsensus without any univalue (Luke Dashjr)
…t any univalue 8a270b2 Bugfix: Allow building libbitcoinconsensus without any univalue (Luke Dashjr)
No description provided.