Join GitHub today
GitHub is home to over 20 million developers working together to host and review code, manage projects, and build software together.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
Already on GitHub? Sign in to your account
Bugfix: Allow building libbitcoinconsensus without any univalue #8293
Conversation
|
Concept ACK. A few nits:
|
laanwj
added
the
Build system
label
Jun 30, 2016
|
It's conceivable that at some point bitcoin-tx could be freed of the univalue dependency as well, so I'm not sure it makes sense to do the dedicated var? |
|
I don't think that's realistic. bitcoin-tx uses JSON objects in various places in the interface |
|
@luke-jr My only concern is that "system_univalue" should not be equated to "don't use any univalue". renaming to need_univalue would suffice. |
|
Ok, let's rename it then. |
|
Renamed. |
|
Thanks. utACK. |
laanwj
merged commit 8a270b2
into
bitcoin:master
Aug 13, 2016
1 check passed
added a commit
that referenced
this pull request
Aug 13, 2016
|
ut ACK |
|
Needs backport to 0.13. |
luke-jr commentedJun 30, 2016
No description provided.