New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Doc] Update bips.md for CSV softfork. #8303

Merged
merged 1 commit into from Jul 8, 2016

Conversation

Projects
None yet
4 participants
@fanquake
Member

fanquake commented Jul 5, 2016

Fixes half of #8131

@laanwj laanwj added the Docs label Jul 6, 2016

@paveljanik

This comment has been minimized.

Show comment
Hide comment
@paveljanik

paveljanik Jul 6, 2016

Contributor

ACK ab0c35a

Contributor

paveljanik commented Jul 6, 2016

ACK ab0c35a

@btcdrak

This comment has been minimized.

Show comment
Hide comment
@btcdrak
Member

btcdrak commented Jul 6, 2016

ACK ab0c35a

@laanwj

This comment has been minimized.

Show comment
Hide comment
@laanwj

laanwj Jul 8, 2016

Member

Tested ACK ab0c35a according to definition clarified in bitcoin/bips#400

VersionBitsBlockState(prev=chainActive[419326], ..., Consensus::DEPLOYMENT_CSV) is THRESHOLD_LOCKED_IN
VersionBitsBlockState(prev=chainActive[419327], ..., Consensus::DEPLOYMENT_CSV) is THRESHOLD_ACTIVE
VersionBitsBlockState(prev=chainActive[419328], ..., Consensus::DEPLOYMENT_CSV) is THRESHOLD_ACTIVE
Member

laanwj commented Jul 8, 2016

Tested ACK ab0c35a according to definition clarified in bitcoin/bips#400

VersionBitsBlockState(prev=chainActive[419326], ..., Consensus::DEPLOYMENT_CSV) is THRESHOLD_LOCKED_IN
VersionBitsBlockState(prev=chainActive[419327], ..., Consensus::DEPLOYMENT_CSV) is THRESHOLD_ACTIVE
VersionBitsBlockState(prev=chainActive[419328], ..., Consensus::DEPLOYMENT_CSV) is THRESHOLD_ACTIVE

@laanwj laanwj merged commit ab0c35a into bitcoin:master Jul 8, 2016

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

laanwj added a commit that referenced this pull request Jul 8, 2016

Merge #8303: [Doc] Update bips.md for CSV softfork.
ab0c35a [Doc] Update bips.md for CSV softfork. (fanquake)

@fanquake fanquake deleted the fanquake:bips-csv-softfork branch Oct 4, 2016

codablock added a commit to codablock/dash that referenced this pull request Sep 19, 2017

Merge #8303: [Doc] Update bips.md for CSV softfork.
ab0c35a [Doc] Update bips.md for CSV softfork. (fanquake)

codablock added a commit to codablock/dash that referenced this pull request Dec 27, 2017

Merge #8303: [Doc] Update bips.md for CSV softfork.
ab0c35a [Doc] Update bips.md for CSV softfork. (fanquake)

codablock added a commit to codablock/dash that referenced this pull request Dec 28, 2017

Merge #8303: [Doc] Update bips.md for CSV softfork.
ab0c35a [Doc] Update bips.md for CSV softfork. (fanquake)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment