New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[travis] Update SDK_URL #8304

Merged
merged 1 commit into from Jul 7, 2016

Conversation

Projects
None yet
4 participants
@MarcoFalke
Member

MarcoFalke commented Jul 5, 2016

@theuni @jonasschnelli Not sure on this one but the core sever can use whitelisting to avoid DOS and "other things".

@luke-jr

This comment has been minimized.

Show comment
Hide comment
@luke-jr

luke-jr Jul 5, 2016

Member

Wherever it is, please ensure all the Travis IPs get whitelisted. They're currently not, so Mac builds are failing for at least Knots.

Member

luke-jr commented Jul 5, 2016

Wherever it is, please ensure all the Travis IPs get whitelisted. They're currently not, so Mac builds are failing for at least Knots.

@MarcoFalke

This comment has been minimized.

Show comment
Hide comment
@MarcoFalke

MarcoFalke Jul 5, 2016

Member

Mac builds are failing for at least Knots.

I am wondering if this was fixed for 0.13 by #8067.

Member

MarcoFalke commented Jul 5, 2016

Mac builds are failing for at least Knots.

I am wondering if this was fixed for 0.13 by #8067.

@luke-jr

This comment has been minimized.

Show comment
Hide comment
@luke-jr

luke-jr Jul 5, 2016

Member

I don't see why it would be?

Member

luke-jr commented Jul 5, 2016

I don't see why it would be?

@MarcoFalke

This comment has been minimized.

Show comment
Hide comment
@MarcoFalke

MarcoFalke Jul 5, 2016

Member

I don't see why it never happened in the bitcoin core repo, or did I just miss it? As #8067 and previous pulls removed the special flags for the bitcoin repo, it should happen for us as well...

Member

MarcoFalke commented Jul 5, 2016

I don't see why it never happened in the bitcoin core repo, or did I just miss it? As #8067 and previous pulls removed the special flags for the bitcoin repo, it should happen for us as well...

@luke-jr

This comment has been minimized.

Show comment
Hide comment
@luke-jr

luke-jr Jul 5, 2016

Member

Not sure, maybe Travis reuses the same servers for repositories.

Member

luke-jr commented Jul 5, 2016

Not sure, maybe Travis reuses the same servers for repositories.

@jonasschnelli

This comment has been minimized.

Show comment
Hide comment
@jonasschnelli

jonasschnelli Jul 6, 2016

Member

Travis seems happy now. I guess @theuni did update the whitelist.
Does travis use different outbound IPs?

I'll try now to re-trigger travis a couple of times to make sure it will work on different travis instances.

Member

jonasschnelli commented Jul 6, 2016

Travis seems happy now. I guess @theuni did update the whitelist.
Does travis use different outbound IPs?

I'll try now to re-trigger travis a couple of times to make sure it will work on different travis instances.

@luke-jr

This comment has been minimized.

Show comment
Hide comment
@luke-jr

luke-jr Jul 6, 2016

Member

It seems to be reliably failing for the bitcoinknots/bitcoin repo at least as of a week ago. I just started a retry here: https://travis-ci.org/bitcoinknots/bitcoin/builds/142818285

For reference, the full IP range is supposedly at: https://docs.travis-ci.com/user/ip-addresses/

Member

luke-jr commented Jul 6, 2016

It seems to be reliably failing for the bitcoinknots/bitcoin repo at least as of a week ago. I just started a retry here: https://travis-ci.org/bitcoinknots/bitcoin/builds/142818285

For reference, the full IP range is supposedly at: https://docs.travis-ci.com/user/ip-addresses/

@theuni

This comment has been minimized.

Show comment
Hide comment
@theuni

theuni Jul 6, 2016

Member

I'm investigating this now. The ranges should be enabled, but I'm seeing failures that I can't pinpoint.

Member

theuni commented Jul 6, 2016

I'm investigating this now. The ranges should be enabled, but I'm seeing failures that I can't pinpoint.

@theuni

This comment has been minimized.

Show comment
Hide comment
@theuni

theuni Jul 6, 2016

Member

I believe I've tracked this down to a local server config issue. IPs weren't always presented correctly (hooray, Cloudflare!), so the filtering didn't work as expected. It should be pretty clear after a few travis builds if all is in order now.

Member

theuni commented Jul 6, 2016

I believe I've tracked this down to a local server config issue. IPs weren't always presented correctly (hooray, Cloudflare!), so the filtering didn't work as expected. It should be pretty clear after a few travis builds if all is in order now.

@theuni

This comment has been minimized.

Show comment
Hide comment
@theuni

theuni Jul 7, 2016

Member

ACK. This should be good to go now.

Member

theuni commented Jul 7, 2016

ACK. This should be good to go now.

@jonasschnelli jonasschnelli merged commit fa6ad56 into bitcoin:master Jul 7, 2016

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

jonasschnelli added a commit that referenced this pull request Jul 7, 2016

Merge #8304: [travis] Update SDK_URL
fa6ad56 [travis] Update SDK_URL (MarcoFalke)

@MarcoFalke MarcoFalke deleted the MarcoFalke:Mf1606-travisSDKURL branch Jul 7, 2016

codablock added a commit to codablock/dash that referenced this pull request Sep 19, 2017

Merge #8304: [travis] Update SDK_URL
fa6ad56 [travis] Update SDK_URL (MarcoFalke)

codablock added a commit to codablock/dash that referenced this pull request Dec 27, 2017

Merge #8304: [travis] Update SDK_URL
fa6ad56 [travis] Update SDK_URL (MarcoFalke)

codablock added a commit to codablock/dash that referenced this pull request Dec 28, 2017

Merge #8304: [travis] Update SDK_URL
fa6ad56 [travis] Update SDK_URL (MarcoFalke)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment