New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gitian: Don't require sudo for Linux. #8315

Merged
merged 1 commit into from Jul 8, 2016

Conversation

Projects
None yet
3 participants
@theuni
Member

theuni commented Jul 8, 2016

Fixes #8212. See commit message for details.

This simply wraps gcc/g++ rather than requiring a new descriptor.

gitian: use a wrapped gcc/g++ to avoid the need for a system change
C_INCLUDE_PATH and CPLUS_INCLUDE_PATH work globally as though -isystem was used
for each invocation.

Since that changes the build results, force a rebuild of x86 depends by adding
the value to $HOST_ID_SALT.
@laanwj

This comment has been minimized.

Show comment
Hide comment
@laanwj

laanwj Jul 8, 2016

Member

Nice workaround.
utACK, going to test

Member

laanwj commented Jul 8, 2016

Nice workaround.
utACK, going to test

@laanwj laanwj added this to the 0.13.0 milestone Jul 8, 2016

@jonasschnelli

This comment has been minimized.

Show comment
Hide comment
@jonasschnelli
Member

jonasschnelli commented Jul 8, 2016

@laanwj

This comment has been minimized.

Show comment
Hide comment
@laanwj

laanwj Jul 8, 2016

Member

I have successfully built a full set of linux executables with this patch and #8314 applied. This solves #8212.
ACK 099d4b0

Member

laanwj commented Jul 8, 2016

I have successfully built a full set of linux executables with this patch and #8314 applied. This solves #8212.
ACK 099d4b0

@laanwj laanwj merged commit 099d4b0 into bitcoin:master Jul 8, 2016

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

laanwj added a commit that referenced this pull request Jul 8, 2016

Merge #8315: gitian: Don't require sudo for Linux.
099d4b0 gitian: use a wrapped gcc/g++ to avoid the need for a system change (Cory Fields)

codablock added a commit to codablock/dash that referenced this pull request Sep 19, 2017

Merge bitcoin#8315: gitian: Don't require sudo for Linux.
099d4b0 gitian: use a wrapped gcc/g++ to avoid the need for a system change (Cory Fields)

@schinzelh schinzelh referenced this pull request Oct 20, 2017

Closed

[WIP] Update build system to Bitcoin 0.13.2 #1692

22 of 24 tasks complete

codablock added a commit to codablock/dash that referenced this pull request Dec 27, 2017

Merge bitcoin#8315: gitian: Don't require sudo for Linux.
099d4b0 gitian: use a wrapped gcc/g++ to avoid the need for a system change (Cory Fields)

codablock added a commit to codablock/dash that referenced this pull request Dec 28, 2017

Merge bitcoin#8315: gitian: Don't require sudo for Linux.
099d4b0 gitian: use a wrapped gcc/g++ to avoid the need for a system change (Cory Fields)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment