Join GitHub today
GitHub is home to over 20 million developers working together to host and review code, manage projects, and build software together.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
Already on GitHub? Sign in to your account
[mempool] Fix relaypriority calculation error #8357
Conversation
MarcoFalke
changed the title from
Update coins.cpp
to
[Wallet] Fix relaypriority calculation error
Jul 18, 2016
MarcoFalke
added
the
Wallet
label
Jul 18, 2016
|
I‘m so sorry ! for this pull request, I try three times. |
|
No worries. There is always bitcoin-core-dev on freenode. We are happy to help with git issues. |
|
@MarcoFalke thanks, and how can i delete the two closed pull request i created before? |
Only github admins can delete pull requests, but don't worry about them. |
|
@laanwj Thank you for your reply. |
|
@maiiz You can still try to adjust the commit message locally (with git)
|
|
@MarcoFalke i change the commit message as you teached! |
|
utACK 11d7cd5 |
|
utACK |
|
... although this has nothing to do with the wallet? Commit message should probably be fixed. |
MarcoFalke
added
Mempool
and removed
Wallet
labels
Sep 11, 2016
MarcoFalke
changed the title from
[Wallet] Fix relaypriority calculation error
to
[CCoinsViewCache] Fix relaypriority calculation error
Sep 11, 2016
MarcoFalke
changed the title from
[CCoinsViewCache] Fix relaypriority calculation error
to
[mempool] Fix relaypriority calculation error
Sep 11, 2016
|
@luke-jr should i change the commit message again?
|
|
@maiiz Sorry for the confusion: I think the mempool, miner and wallet use this logic, but each have the code copied and this bug can only be found in one of the instances... You can remove the tag altogether from the commit message just to be safe. |
|
utACK |
|
utACK 94a34a5 |
maiiz commentedJul 18, 2016
•
Edited 1 time
-
maiiz
Aug 3, 2016
[mempool] Fix relaypriority calculation error
Fixes #8334