Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

[mempool] Fix relaypriority calculation error #8357

Merged
merged 1 commit into from Sep 27, 2016

Conversation

Projects
None yet
5 participants
Contributor

maiiz commented Jul 18, 2016

[mempool] Fix relaypriority calculation error

Fixes #8334

@MarcoFalke MarcoFalke changed the title from Update coins.cpp to [Wallet] Fix relaypriority calculation error Jul 18, 2016

@MarcoFalke MarcoFalke added the Wallet label Jul 18, 2016

Contributor

maiiz commented Jul 18, 2016

I‘m so sorry ! for this pull request, I try three times.

Member

MarcoFalke commented Jul 18, 2016

No worries. There is always bitcoin-core-dev on freenode. We are happy to help with git issues.

Contributor

maiiz commented Jul 18, 2016

@MarcoFalke thanks, and how can i delete the two closed pull request i created before?

Owner

laanwj commented Jul 18, 2016

and how can i delete the two closed pull request i created before?

Only github admins can delete pull requests, but don't worry about them.

Contributor

maiiz commented Jul 18, 2016

@laanwj Thank you for your reply.

Member

MarcoFalke commented Aug 3, 2016

@maiiz You can still try to adjust the commit message locally (with git)

git clone $yourrepo
cd $yourrepo
git checkout maiiz-patch-1
git commit --amend
git push origin maiiz-patch-1 -f
Contributor

maiiz commented Aug 29, 2016

@MarcoFalke i change the commit message as you teached!

Member

MarcoFalke commented Aug 29, 2016

utACK 11d7cd5

Member

luke-jr commented Sep 10, 2016

utACK

Member

luke-jr commented Sep 10, 2016

... although this has nothing to do with the wallet? Commit message should probably be fixed.

@MarcoFalke MarcoFalke added Mempool and removed Wallet labels Sep 11, 2016

@MarcoFalke MarcoFalke changed the title from [Wallet] Fix relaypriority calculation error to [CCoinsViewCache] Fix relaypriority calculation error Sep 11, 2016

@MarcoFalke MarcoFalke changed the title from [CCoinsViewCache] Fix relaypriority calculation error to [mempool] Fix relaypriority calculation error Sep 11, 2016

Contributor

maiiz commented Sep 13, 2016

@luke-jr should i change the commit message again?
change like this?

[wallet] Fix relaypriority calculation error -> [mempool] Fix relaypriority calculation error 
Member

MarcoFalke commented Sep 13, 2016

@maiiz Sorry for the confusion: I think the mempool, miner and wallet use this logic, but each have the code copied and this bug can only be found in one of the instances... You can remove the tag altogether from the commit message just to be safe.

Member

gmaxwell commented Sep 27, 2016

utACK

Member

MarcoFalke commented Sep 27, 2016

utACK 94a34a5

@laanwj laanwj merged commit 94a34a5 into bitcoin:master Sep 27, 2016

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

laanwj added a commit that referenced this pull request Sep 27, 2016

Merge #8357: [mempool] Fix relaypriority calculation error
94a34a5 Fix relaypriority calculation error (maiiz)

@luke-jr luke-jr referenced this pull request Oct 25, 2016

Merged

0.13.2 backports #9011

laanwj added a commit to laanwj/bitcoin that referenced this pull request Oct 25, 2016

laanwj added a commit to laanwj/bitcoin that referenced this pull request Oct 27, 2016

codablock added a commit to codablock/dash that referenced this pull request Sep 19, 2017

Merge #8357: [mempool] Fix relaypriority calculation error
94a34a5 Fix relaypriority calculation error (maiiz)

codablock added a commit to codablock/dash that referenced this pull request Sep 27, 2017

Merge #8357: [mempool] Fix relaypriority calculation error
94a34a5 Fix relaypriority calculation error (maiiz)

codablock added a commit to codablock/dash that referenced this pull request Oct 12, 2017

Merge #8357: [mempool] Fix relaypriority calculation error
94a34a5 Fix relaypriority calculation error (maiiz)

schinzelh added a commit to dashpay/dash that referenced this pull request Oct 23, 2017

codablock added a commit to codablock/dash that referenced this pull request Oct 23, 2017

Merge #8357: [mempool] Fix relaypriority calculation error
94a34a5 Fix relaypriority calculation error (maiiz)

codablock added a commit to codablock/dash that referenced this pull request Oct 26, 2017

Merge #8357: [mempool] Fix relaypriority calculation error
94a34a5 Fix relaypriority calculation error (maiiz)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment