Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
Rename "block cost" to "block weight" #8363
As @laanwj observed, this is somewhat of a tedious change to make, but I do think that it'd be better to make this change now than live with the confusing "cost" terminology indefinitely into the future.
If we go with this, we should re-open bitcoin/bips#420 and make the corresponding change to the BIP.
I didn't change qt/bitcoinstrings.cpp, which -- if I am understanding correctly -- was just changed so that we wouldn't translate the help language for
There's one more language reconciliation we should still do after this, which is that BIP 141 doesn't define "sigop cost", yet we refer to "sigop cost" as a term both in RPC calls (eg getblocktemplate) and throughout the code (comments, variables, function names, etc). I think it'd be best to pick a term, use that in the BIP, and then make a pass through the code to be compatible -- presumably the simplest thing would be to just define "sigop cost" in BIP 141.