[Qt] Add out-of-sync modal info layer #8371

jonasschnelli · Jul 19, 2016

This change will slide in a semi transparent modal info layer in out-of-sync state resulting in a more prominent warning. Users can hide the modal info layer by pressing on "Hide".
Clicking on the out-of-sync warning icons will re-display the modal info layer.

In the modal info layer, the user can get three new values:

amount of blocks left
estimated time left until in-sync
progress increase per hour

instagibbs · Jul 20, 2016

"Progress increase per hour" is a bit weird sounding to me, maybe "Sync progress per hour"?

laanwj · Jul 20, 2016

Looks very nice!

laanwj · Jul 28, 2016

Looks like the font color should not depend on the theme?
Maybe add some more text after "...but this process has not completed yet", to make it more concrete "this means that recent transactions will not be visible, and the balance will not be up-to-date until this process has completed."

jonasschnelli · Jul 28, 2016

Added the second info text and made sure, the font will be blackish (force push).

fanquake · Aug 8, 2016

Testing this, and clicking hide doesn't seem to do anything?
Also, If your opening a close-to, or recently synced wallet, should the modal disappear automatically once it reaches 100%?

OS X screenshots:

Also, this looks like a new compiler warning.

  CXX      qt/qt_libbitcoinqt_a-bitcoingui.o
qt/bitcoingui.cpp:118:5: warning: field 'spinnerFrame' will be initialized after field 'modalOverlay' [-Wreorder]
    spinnerFrame(0),
    ^
1 warning generated.

jonasschnelli · Aug 12, 2016

@fanquake: It should hide automatically if you are in sync,.. but only, If you haven't opened it manually (by pressing the warning icons).
Not sure if it should also hide in that case, but probably.

Joukehofman · Aug 19, 2016

Look great! Maybe add to the warning text that it's also not possible to send bitcoins?

jonasschnelli · Aug 26, 2016

Fixed warning. Added a short text passage "Spending bitcoins is not possible during that phase!".

sipa · Aug 26, 2016

Does the "This process is not complete yet" disappear when 100% is reached, but the window is still open?

jonasschnelli · Aug 26, 2016

@sipa: yes. It will (https://github.com/bitcoin/bitcoin/pull/8371/files#diff-0db7dd184df07a48c307ccc182021a68R776). But only if you not have manually opened the "window" by clicking on the alert icons (then it will stay intentionally).

sipa · Aug 26, 2016

No, I mean that if you have manually clicked it, and the window does stay open, does the "This process has not completes yet" text also stay? Because that is very confusing...

jonasschnelli · Aug 26, 2016

Ah. I get your point. Maybe force closing then would make sense (or changing the text in the upper section [more complicate]).

sipa · Aug 26, 2016

I think force closing is fine.

MarcoFalke · Aug 26, 2016

I think force closing is fine.

Agree

jonasschnelli · Aug 26, 2016

Updated so that the layer/window does force close when the we detect in-sync state.

sipa · Aug 26, 2016

The "number of blocks left" goes up and down for a while (presumably because the headers aren't processed yet?)... if the tip header is too far in the past, it may be better to say "unknown" there.

fanquake · Aug 26, 2016

Updated OS X screenshot, the hiding issue seems to be fixed now.

luke-jr · Sep 10, 2016

Looks like the font color should not depend on the theme?

Rather, the background colour should depend on the theme also? Why is this overriding the theme?

flack · Sep 12, 2016

Shouldn't this dialog also have a headline of some sort (e.g. "Wallet out of sync")?

Because if I look at the screenshot, I only see the progress data, and the text starts with "The displayed information may be out of date", but in fact, it's not the currently displayed data (progress information) that is out of date, but the stuff in the wallet, which is obscured by the overlay.

jonasschnelli · Sep 12, 2016

@luke-jr: I think creating nice visualizations is difficult with the presumption to only use theme based colors.

@flack: Indeed. The term "the displayed information... " can look like its referred to the data below (in the same overlay). I have plans to overhaul this PR soon.

jonasschnelli · Sep 13, 2016

Updated with recommendation from @sipa to hide the remaining blocks during headers-first during IBD.

MarcoFalke · Sep 21, 2016

MarcoFalke approved these changes Sep 21, 2016

View changes

Tested-only ACK. Found a few style nits. (You can fix them in a separate fixup commit)

ACK d8b062e

style nit: brackets are "required" for the else when they are used for the if.

Where does it say 10 in the source code?

nit

static const int MAX_SAMPLES = 5000;

nit: I don't think this is proper English. Idk, get rid of the Of?

MarcoFalke · Sep 21, 2016

Looks good to merge

jonasschnelli · Sep 21, 2016

Fixed nits reported by @MarcoFalke.
@MarcoFalke: can you re-ack?

luke-jr · Sep 21, 2016

@jonasschnelli On the contrary, violating the theme contradicts the goal of nice visualisations.

jonasschnelli · Sep 21, 2016

@luke-jr: I think adding a black overlay with white text does not directly violates the theme. It just will result in a more controllable look and feel.

luke-jr · Sep 21, 2016

Software controlling look-and-feel means the user's chosen look-and-feel is being ignored. Presumably the user has chosen them because they like it, so violating them simply won't be nice.

jonasschnelli · Sep 21, 2016

I think themes are there for a reason.
Using the theme colors might result in loosing the optical effect which is there for a reason. The back background with the white info layer should imply that the informations within the layer are on a different level of importance.

But happy if someone likes to try migrating this to the theme colors.

luke-jr · Sep 21, 2016

(BTW, I don't mean to imply theme concerns need to interfere in merging this. By all means, feel free. We can work on theming later.)

gmaxwell · Sep 22, 2016

Too much text, esp too much bolded text. I automatically don't read the top part (though I did in the original version). Also "Spending bitcoins is not possible during that phase!" is not true.

sipa · Sep 23, 2016

Well you can't spend funds your client hasn't seen the receival of.

gmaxwell · Sep 23, 2016

@sipa Yes, but you can spend anything you can see... This is a common point of confusion already. And in the common case where you had bitcoin off for the last month, but received no payment since then, you're good to go for sending.

jonasschnelli · Sep 23, 2016

@gmaxwell: would you be willing providing a better text?

I agree that "spending Bitcoins is not possible" is not true and can lead to confusion, especially if one catches up just a couple of days (the info-layer will also be shown then).

MarcoFalke · Sep 23, 2016

MarcoFalke reviewed Sep 23, 2016

View changes

Maybe

s/possible/recommended/

?

Or what about [...]Spending bitcoins may not be possible[...]?

Fine, I think either is better.

jonasschnelli · Sep 23, 2016

Force pushed a text- and bold-section-change.
This is how it looks now:

MarcoFalke · Sep 23, 2016

Are you sure you pushed the text change?

jonasschnelli · Sep 23, 2016

Pushed now..

MarcoFalke · Sep 23, 2016

ACK 08827df

MarcoFalke · Sep 25, 2016

MarcoFalke reviewed Sep 25, 2016

View changes

Why is this needed?

Oh, nvm. It is needed so a header update is not accidentally lost. Still, this makes the gui unresponsive when -reindex is used...

Xekyo · Sep 26, 2016

Instead of "this process" and "that phase" I would repeat "synchronization":

The displayed information may be out of date.
Your wallet automatically synchronizes with the Bitcoin network while connected, but synchronization has not completed yet. Recent transactions will not be visible until your wallet catches up to the network. Your balance will update as transactions are processed.
Spending bitcoins may not be possible until synchronization has finished.

jonasschnelli added the GUI label Jul 19, 2016

jonasschnelli added this to the 0.14 milestone Jul 28, 2016

[Qt] add out-of-sync modal info layer

This commit was signed with a verified signature.

jonasschnelli Jonas Schnelli

GPG key ID: 29D4BCB6416F53EC Learn about signing commits

e3245b4

[Qt] only update "amount of blocks left" when the header chain is in-…
…sync

This commit was signed with a verified signature.

jonasschnelli Jonas Schnelli

GPG key ID: 29D4BCB6416F53EC Learn about signing commits

d8b062e

[Qt] modalinfolayer: removed unused comments, renamed signal, code st…
…yle overhaul

This commit was signed with a verified signature.

jonasschnelli Jonas Schnelli

GPG key ID: 29D4BCB6416F53EC Learn about signing commits

08827df

jonasschnelli merged commit 08827df into bitcoin:master Sep 23, 2016
1 check passed

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

This was referenced Sep 24, 2016

Closed

Wallet suggestion: Hide receive addresses until fully synced. #7235

Closed

Unsynced wallet status should be more apparent #8060

Closed

WIP: [qt] rework sync-overlay #8809

luke-jr added a commit to bitcoinknots/bitcoin that referenced this pull request Oct 20, 2016

[Refactor] refactor function that forms human readable text out of a …
…timeoffset Github-Pull: #8371 Rebased-From: 0904c3c

cb80e00

luke-jr added a commit to bitcoinknots/bitcoin that referenced this pull request Oct 20, 2016

[Qt] make Out-Of-Sync warning icon clickable
Github-Pull: #8371 Rebased-From: bd44a04

8e325b4

luke-jr added a commit to bitcoinknots/bitcoin that referenced this pull request Oct 20, 2016

[Qt] Always pass the numBlocksChanged signal for headers tip changed
Github-Pull: #8371 Rebased-From: a001f18

4f4d641

luke-jr added a commit to bitcoinknots/bitcoin that referenced this pull request Oct 20, 2016

[Qt] ClientModel add method to get the height of the header chain
Github-Pull: #8371 Rebased-From: e47052f

88c4ec6

luke-jr added a commit to bitcoinknots/bitcoin that referenced this pull request Oct 20, 2016

[Qt] add out-of-sync modal info layer
Github-Pull: #8371 Rebased-From: e3245b4

4d7ccc5

luke-jr added a commit to bitcoinknots/bitcoin that referenced this pull request Oct 20, 2016

[Qt] only update "amount of blocks left" when the header chain is in-…
…sync Github-Pull: #8371 Rebased-From: d8b062e

d1bc374

luke-jr added a commit to bitcoinknots/bitcoin that referenced this pull request Oct 20, 2016

[Qt] modalinfolayer: removed unused comments, renamed signal, code st…
…yle overhaul Github-Pull: #8371 Rebased-From: 08827df

752f57a

This was referenced Oct 20, 2016

Closed

GUI hangs during sync #8984

Closed

TODO for release notes 0.14.0 #8455

Closed

Design for a bitcoin wallet #9639

codablock referenced this pull request in dashpay/dash Sep 8, 2017
Merged
Backport Bitcoin Qt/Gui changes up to 0.14.x part 2 #1615

+        +            modalOverlay->setKnownBestHeight(clientModel->getHeaderTipHeight(), QDateTime::fromTime_t(clientModel->getHeaderTipTime()));
+        +        }
+        +        else
+        +            modalOverlay->tipUpdate(count, blockDate, nVerificationProgress);

+        +    // show progress speed if we have more then one sample
+        +    if (blockProcessTime.size() >= 2)
+        +    {
+        +        // try to get the window from the last 500 seconds or at least 10 samples

@@ -38,6 +38,10 @@ class WalletFrame : public QFrame
              void showOutOfSyncWarning(bool fShow);
+        +Q_SIGNALS:
+        +    /** Notify that the user has requested more information about the out-of-sync warning */
+        +    void requestedOfSyncWarningInfo();

+        +                </font>
+        +               </property>
+        +               <property name="text">
+        +                <string>This means that recent transactions will not be visible, and the balance will not be up-to-date until this process has completed. Spending bitcoins is not possible during that phase!</string>

@@ -234,7 +250,7 @@ static void BlockTipChanged(ClientModel *clientmodel, bool initialSync, const CB
              int64_t& nLastUpdateNotification = fHeader ? nLastHeaderTipUpdateNotification : nLastBlockTipUpdateNotification;
              // if we are in-sync, update the UI regardless of last update time
-        -    if (!initialSync || now - nLastUpdateNotification > MODEL_UPDATE_DELAY) {
+        +    if (fHeader || !initialSync || now - nLastUpdateNotification > MODEL_UPDATE_DELAY) {

bitcoin/bitcoin

Join GitHub today

[Qt] Add out-of-sync modal info layer #8371

Conversation

jonasschnelli commented Jul 19, 2016

jonasschnelli added the GUI label Jul 19, 2016

instagibbs commented Jul 20, 2016

laanwj commented Jul 20, 2016

laanwj commented Jul 28, 2016

jonasschnelli commented Jul 28, 2016

jonasschnelli added this to the 0.14 milestone Jul 28, 2016

fanquake commented Aug 8, 2016

jonasschnelli commented Aug 12, 2016

Joukehofman commented Aug 19, 2016

jonasschnelli commented Aug 26, 2016

sipa commented Aug 26, 2016

jonasschnelli added some commits Jul 19, 2016

jonasschnelli commented Aug 26, 2016

sipa commented Aug 26, 2016

jonasschnelli commented Aug 26, 2016

sipa commented Aug 26, 2016

MarcoFalke commented Aug 26, 2016

jonasschnelli commented Aug 26, 2016

sipa commented Aug 26, 2016

fanquake commented Aug 26, 2016

luke-jr commented Sep 10, 2016

flack commented Sep 12, 2016

jonasschnelli commented Sep 12, 2016

jonasschnelli commented Sep 13, 2016

MarcoFalke approved these changes Sep 21, 2016 View changes

MarcoFalke commented Sep 21, 2016

jonasschnelli commented Sep 21, 2016

luke-jr commented Sep 21, 2016

jonasschnelli commented Sep 21, 2016

luke-jr commented Sep 21, 2016

jonasschnelli commented Sep 21, 2016

luke-jr commented Sep 21, 2016

gmaxwell commented Sep 22, 2016

sipa commented Sep 23, 2016

gmaxwell commented Sep 23, 2016

jonasschnelli commented Sep 23, 2016

MarcoFalke reviewed Sep 23, 2016 View changes

jonasschnelli commented Sep 23, 2016

MarcoFalke commented Sep 23, 2016

jonasschnelli commented Sep 23, 2016

MarcoFalke commented Sep 23, 2016

Hide details View details jonasschnelli merged commit 08827df into bitcoin:master Sep 23, 2016 1 check passed

1 check passed

jonasschnelli added a commit that referenced this pull request Sep 23, 2016

This was referenced Sep 24, 2016

MarcoFalke reviewed Sep 25, 2016 View changes

MarcoFalke Sep 25, 2016 • edited Edited 1 time MarcoFalke Sep 26, 2016

Xekyo commented Sep 26, 2016 • edited Edited 1 time Xekyo Sep 26, 2016

luke-jr added a commit to bitcoinknots/bitcoin that referenced this pull request Oct 20, 2016

luke-jr added a commit to bitcoinknots/bitcoin that referenced this pull request Oct 20, 2016

luke-jr added a commit to bitcoinknots/bitcoin that referenced this pull request Oct 20, 2016

luke-jr added a commit to bitcoinknots/bitcoin that referenced this pull request Oct 20, 2016

luke-jr added a commit to bitcoinknots/bitcoin that referenced this pull request Oct 20, 2016

luke-jr added a commit to bitcoinknots/bitcoin that referenced this pull request Oct 20, 2016

luke-jr added a commit to bitcoinknots/bitcoin that referenced this pull request Oct 20, 2016

This was referenced Oct 20, 2016

codablock added a commit to codablock/dash that referenced this pull request Sep 7, 2017

codablock referenced this pull request in dashpay/dash Sep 8, 2017

UdjinM6 added a commit to dashpay/dash that referenced this pull request Sep 9, 2017

MarcoFalke approved these changes Sep 21, 2016

View changes

MarcoFalke reviewed Sep 23, 2016

View changes

jonasschnelli merged commit `08827df` into bitcoin:master Sep 23, 2016
1 check passed

MarcoFalke reviewed Sep 25, 2016

View changes

MarcoFalke Sep 25, 2016 •

Edited 1 time

MarcoFalke
Sep 26, 2016

Xekyo commented Sep 26, 2016 •

Edited 1 time

Xekyo
Sep 26, 2016