New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Wallet]Move SetMinVersion for FEATURE_HD to SetHDMasterKey #8378

Merged
merged 1 commit into from Jul 20, 2016

Conversation

Projects
None yet
5 participants
@pstratem
Contributor

pstratem commented Jul 20, 2016

There's a race condition without this fix.

I think this needs to be tagged for 0.13

@pstratem pstratem changed the title from Move SetMinVersion for FEATURE_HD to SetHDMasterKey to [Wallet]Move SetMinVersion for FEATURE_HD to SetHDMasterKey Jul 20, 2016

@laanwj laanwj added this to the 0.13.0 milestone Jul 20, 2016

@MarcoFalke

This comment has been minimized.

Show comment
Hide comment
@MarcoFalke
Member

MarcoFalke commented Jul 20, 2016

utACK 6523fca

@jonasschnelli

This comment has been minimized.

Show comment
Hide comment
@jonasschnelli

jonasschnelli Jul 20, 2016

Member

Thanks Patrick. Makes sense.
utACK 6523fca

Member

jonasschnelli commented Jul 20, 2016

Thanks Patrick. Makes sense.
utACK 6523fca

@paveljanik

This comment has been minimized.

Show comment
Hide comment
@paveljanik

paveljanik Jul 20, 2016

Contributor

ACK 6523fca

Contributor

paveljanik commented Jul 20, 2016

ACK 6523fca

@laanwj laanwj merged commit 6523fca into bitcoin:master Jul 20, 2016

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

laanwj added a commit that referenced this pull request Jul 20, 2016

Merge #8378: [Wallet]Move SetMinVersion for FEATURE_HD to SetHDMasterKey
6523fca Move SetMinVersion for FEATURE_HD to SetHDMasterKey (Patrick Strateman)

laanwj added a commit that referenced this pull request Jul 20, 2016

@laanwj laanwj removed the Needs backport label Jul 20, 2016

codablock added a commit to codablock/dash that referenced this pull request Jan 31, 2018

Merge #8378: [Wallet]Move SetMinVersion for FEATURE_HD to SetHDMasterKey
6523fca Move SetMinVersion for FEATURE_HD to SetHDMasterKey (Patrick Strateman)

codablock added a commit to codablock/dash that referenced this pull request Jan 31, 2018

Merge #8378: [Wallet]Move SetMinVersion for FEATURE_HD to SetHDMasterKey
6523fca Move SetMinVersion for FEATURE_HD to SetHDMasterKey (Patrick Strateman)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment