Add witness data output to TxInError messages #8384

Open
wants to merge 2 commits into
from

Projects

None yet

5 participants

@instagibbs
Contributor

Makes for easier debugging.

@mcelrath

Tested ACK

Works fine with signrawtransaction that fails to fully sign the transaction. (empty witness)

@NicolasDorier
Member

utACK 73c5eb1

@laanwj
Member
laanwj commented Aug 3, 2016

Does this need to be tested in the RPC tests?

@instagibbs
Contributor

@laanwj added basic test check for new field

@luke-jr luke-jr added a commit to bitcoinknots/bitcoin that referenced this pull request Oct 20, 2016
@instagibbs @luke-jr instagibbs + luke-jr Add witness data output to TxInError messages
Github-Pull: #8384
Rebased-From: 73c5eb1
c0631fa
@luke-jr luke-jr added a commit to bitcoinknots/bitcoin that referenced this pull request Oct 20, 2016
@instagibbs @luke-jr instagibbs + luke-jr Expand signrawtransaction.py to cover error witness checking
Github-Pull: #8384
Rebased-From: 464c826
34bbc0d
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment