New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Wallet] Correct hdmasterkeyid/masterkeyid name confusion #8390

Merged
merged 1 commit into from Jul 22, 2016

Conversation

Projects
None yet
3 participants
@jonasschnelli
Member

jonasschnelli commented Jul 21, 2016

At the moment, getwalletinfo() reports with a new field called masterkeyid while validateaddress() report a field called hdmasterkeyid.

This PR will change getwalletinfo() to also use hdmasterkeyid for better consistency.

@jonasschnelli jonasschnelli changed the title from [Wallet] Correct hdmasterkeyid/hdmasterkey name confusion to [Wallet] Correct hdmasterkeyid/masterkeyid name confusion Jul 21, 2016

@MarcoFalke

This comment has been minimized.

Show comment
Hide comment
@MarcoFalke

MarcoFalke Jul 21, 2016

Member

trivial ACK b50e1ac?w=

Member

MarcoFalke commented Jul 21, 2016

trivial ACK b50e1ac?w=

@MarcoFalke MarcoFalke added this to the 0.13.0 milestone Jul 21, 2016

@paveljanik

This comment has been minimized.

Show comment
Hide comment
@paveljanik

paveljanik Jul 22, 2016

Contributor

ACK b50e1ac

Contributor

paveljanik commented Jul 22, 2016

ACK b50e1ac

@jonasschnelli jonasschnelli merged commit b50e1ac into bitcoin:master Jul 22, 2016

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

jonasschnelli added a commit that referenced this pull request Jul 22, 2016

Merge #8390: [Wallet] Correct hdmasterkeyid/masterkeyid name confusion
b50e1ac [Wallet] Correct hdmasterkeyid/masterkeyid name confusion (Jonas Schnelli)

laanwj added a commit that referenced this pull request Jul 25, 2016

@MarcoFalke

This comment has been minimized.

Show comment
Hide comment
@MarcoFalke

MarcoFalke Jul 31, 2016

Member

Removing backport label per 73adfe3

Member

MarcoFalke commented Jul 31, 2016

Removing backport label per 73adfe3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment