New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix: Use pre-BIP141 sigops until segwit activates (GBT) #8489

Merged
merged 2 commits into from Aug 10, 2016

Conversation

Projects
None yet
4 participants
@luke-jr
Member

luke-jr commented Aug 8, 2016

We are currently giving BIP141 sigop values in block templates even before BIP141 is active.

This is broken in 0.13 and will need a backport. (although not sure it's worth delaying 0.13.0 over?)

Includes RPC test improvements to catch the issue, which now pass with the fix.

@luke-jr

This comment has been minimized.

Show comment
Hide comment
@luke-jr

luke-jr Aug 8, 2016

Member

Only known practical real-world effect: Eloipool currently ignores sigoplimit, but will enforce 19,488 "sigops"; this bug will cause it to enforce instead 4,872. This seems sufficiently large that it shouldn't affect ordinary blocks, but I'm not sure how malicious transactions might factor into it.

Member

luke-jr commented Aug 8, 2016

Only known practical real-world effect: Eloipool currently ignores sigoplimit, but will enforce 19,488 "sigops"; this bug will cause it to enforce instead 4,872. This seems sufficiently large that it shouldn't affect ordinary blocks, but I'm not sure how malicious transactions might factor into it.

@sipa

This comment has been minimized.

Show comment
Hide comment
@sipa

sipa Aug 10, 2016

Member

utACK 239cbd2

Member

sipa commented Aug 10, 2016

utACK 239cbd2

@sipa sipa added this to the 0.13.0 milestone Aug 10, 2016

@laanwj laanwj merged commit 239cbd2 into bitcoin:master Aug 10, 2016

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

laanwj added a commit that referenced this pull request Aug 10, 2016

Merge #8489: Bugfix: Use pre-BIP141 sigops until segwit activates (GBT)
239cbd2 qa/rpc-tests/segwit: Test GBT sigops before and after activation (Luke Dashjr)
160f895 Bugfix: Use pre-BIP141 sigops until segwit activates (Luke Dashjr)

laanwj added a commit that referenced this pull request Aug 10, 2016

Bugfix: Use pre-BIP141 sigops until segwit activates
qa/rpc-tests/segwit: Test GBT sigops before and after activation

Github-Pull: #8489
Rebased-From: 160f895 239cbd2
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment