Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
Bugfix: Use pre-BIP141 sigops until segwit activates (GBT) #8489
We are currently giving BIP141 sigop values in block templates even before BIP141 is active.
This is broken in 0.13 and will need a backport. (although not sure it's worth delaying 0.13.0 over?)
Includes RPC test improvements to catch the issue, which now pass with the fix.
Only known practical real-world effect: Eloipool currently ignores sigoplimit, but will enforce 19,488 "sigops"; this bug will cause it to enforce instead 4,872. This seems sufficiently large that it shouldn't affect ordinary blocks, but I'm not sure how malicious transactions might factor into it.