Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build,doc: Update for 0.13.0+ and OpenBSD 5.9 #8604

Merged
merged 2 commits into from Aug 31, 2016

Conversation

@laanwj
Copy link
Member

commented Aug 26, 2016

Build:

  • LevelDB platform was not guessed correctly (it ended up defining -DOS_OPENBSD59 instead of -DOS_OPENBSD). This has been fixed by adding explicit checks for OpenBSD and FreeBSD.
  • On OpenBSD there is no convenience link from python3.5 to python3: add detection for other python interpreter names.
  • If it has to guess the LevelDB OS, print a autoconf warning so that the user can check.

Changes to build-openbsd.md:

  • Python 3 now supported.
  • Bump boost version to 1.61 - one boost patch no longer needed.
  • All checked with OpenBSD 5.9, except for the clang part, I left this as-is for someone adventurous.
  • Mention overriding resource limits, OpenBSD's default ulimit does not suffice for building Bitcoin Core with gcc 4.9.3.

@laanwj laanwj added this to the 0.13.1 milestone Aug 26, 2016

@laanwj

This comment has been minimized.

Copy link
Member Author

commented Aug 26, 2016

@theuni can you take a look at the build system changes?

@paveljanik

This comment has been minimized.

Copy link
Contributor

commented Aug 27, 2016

utACK b96fd9b

laanwj added 2 commits Aug 26, 2016
build: Updates for OpenBSD
- LevelDB platform was not guessed correctly (it ended up defining
  `-DOS_OPENBSD59` instead of `-DOS_OPENBSD`)

- On OpenBSD there is no convenience link from `python3.5` to `python3`:
  add detection for other python interpreter names.

- If it has to guess the LevelDB OS, print a autoconf warning so that
  the user can check.
doc: Update build-openbsd for 0.13.0+ and OpenBSD 5.9
- Python 3 now supported.

- Bump boost version to 1.61 - one boost patch no longer needed.

- All checked with OpenBSD 5.9, except for the clang part, I left this
  as-is for someone adventurous.

- Mention overriding resource limits, OpenBSD's default ulimit does not
  suffice for building Bitcoin Core with gcc 4.9.3.

@laanwj laanwj force-pushed the laanwj:2016_08_openbsd_update branch to 6275123 Aug 28, 2016

@fanquake

This comment has been minimized.

Copy link
Member

commented Aug 31, 2016

Tested ACK compiled 0.13.0 + 6275123 on OpenBSD5.9

Built with VirtualBox 5.1.4 on OS X 10.11 . Didn't check the Clang part.

Needed the autogen.sh changes otherwise I saw the same issues as #8127, so that should be closed when this is merged.

@theuni

This comment has been minimized.

Copy link
Member

commented Aug 31, 2016

utACK 6275123. Looks good to me.

@laanwj laanwj merged commit 6275123 into bitcoin:master Aug 31, 2016

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
laanwj added a commit that referenced this pull request Aug 31, 2016
Merge #8604: build,doc: Update for 0.13.0+ and OpenBSD 5.9
6275123 doc: Update build-openbsd for 0.13.0+ and OpenBSD 5.9 (Wladimir J. van der Laan)
883175f build: Updates for OpenBSD (Wladimir J. van der Laan)
@sipa sipa referenced this pull request Sep 7, 2016
codablock added a commit to codablock/dash that referenced this pull request Jan 9, 2018
Merge bitcoin#8604: build,doc: Update for 0.13.0+ and OpenBSD 5.9
6275123 doc: Update build-openbsd for 0.13.0+ and OpenBSD 5.9 (Wladimir J. van der Laan)
883175f build: Updates for OpenBSD (Wladimir J. van der Laan)
codablock added a commit to codablock/dash that referenced this pull request Jan 9, 2018
Merge bitcoin#8604: build,doc: Update for 0.13.0+ and OpenBSD 5.9
6275123 doc: Update build-openbsd for 0.13.0+ and OpenBSD 5.9 (Wladimir J. van der Laan)
883175f build: Updates for OpenBSD (Wladimir J. van der Laan)
andvgal added a commit to energicryptocurrency/energi that referenced this pull request Jan 6, 2019
Merge bitcoin#8604: build,doc: Update for 0.13.0+ and OpenBSD 5.9
6275123 doc: Update build-openbsd for 0.13.0+ and OpenBSD 5.9 (Wladimir J. van der Laan)
883175f build: Updates for OpenBSD (Wladimir J. van der Laan)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants
You can’t perform that action at this time.