Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check for compatibility with download in FindNextBlocksToDownload #8612

Merged
merged 1 commit into from Aug 31, 2016

Conversation

@sipa
Copy link
Member

commented Aug 27, 2016

Fixes #8518 (untested).

Move the witness-compatibility of a peer with downloading to FindNextBlocksToDownload. This should be more efficient than doing it afterwards in SendMessages, and avoids accidentally marking peers as stalling.

cc @MarcoFalke @sdaftuar

@MarcoFalke MarcoFalke added this to the 0.13.1 milestone Aug 27, 2016

@MarcoFalke

This comment has been minimized.

Copy link
Member

commented Aug 27, 2016

Tested ACK 887919c

@gmaxwell

This comment has been minimized.

Copy link
Contributor

commented Aug 27, 2016

utACK, will test.

@gmaxwell

This comment has been minimized.

Copy link
Contributor

commented Aug 31, 2016

ACK.

@laanwj laanwj merged commit 887919c into bitcoin:master Aug 31, 2016

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
laanwj added a commit that referenced this pull request Aug 31, 2016
Merge #8612: Check for compatibility with download in FindNextBlocksT…
…oDownload

887919c Check for compatibility with download in FindNextBlocksToDownload (Pieter Wuille)
@sdaftuar

This comment has been minimized.

Copy link
Member

commented Sep 6, 2016

post-merge utACK

@sipa sipa referenced this pull request Sep 7, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants
You can’t perform that action at this time.