Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.Sign up
Implement NULLDUMMY softfork (BIP147) #8636
Alternative to #8533
This will enforce SCRIPT_VERIFY_NULLDUMMY on all segwit and non-segwit transactions when segwit is activated with BIP9.
As we may need more time to implement LOW_S softfork in a better way (see #8533 (comment)), the alternative plan is to implement only NULLDUMMY softfork in 0.13.1 and leave LOW_S as a policy at this moment.
This is an implementation of BIP147, which could be found at https://github.com/bitcoin/bips/blob/36496946860d71d4460437572e6c4c780b125cad/bip-0147.mediawiki
I propose that reviewers should explicitly acknowledge that this pull request is a correct implementation of a specified version of BIP147. So they should review the relevant codes, for example, in interpreter.cpp.
This is needed because in #8533 we just focused on the PR, but not the consensus codes being activated. NULLDUMMY should be reasonably simple for everything to do more careful review.
For example, a reviewer may use: utACK 482f852, ACK BIP147 3649694