Qt: Show transaction size in transaction details window

[Cocosoft]

Fixes #8125

[sipa]

Wouldn't it be more useful to show the transaction weight? That's what matters for fee estimates etc.

[luke-jr]

I suggest size + feerate-based-on-weight.

[Cocosoft]

@sipa Valid point, I guess I could add that as well.
I'm not sure how to make this easy to understand for the user though.

[jonasschnelli]

I agree with @luke-jr: size + ferrate-based-on-weight

[sipa]

Which size? We have:

• Base size
• Total size (base + witness)
• Virtual size (base + witness/4)
• Weight (4*base + witness)

My assumption was that after segwit, only vsize would matter. For old
transactions it is identical to total and base size, and for others it
remains proportional to fees with that.

[jonasschnelli]

Depends what users will do with the size information. But IMO size should be the "total size" (base + witness). I guess the size has usefulness besides fee calculation.

[sipa]

I agree it may be useful, but total size isn't the first a user should see

• it's not relevant for fee calculation, propagation time, priority, or
  block space usage.

[jonasschnelli]

I agree that the virtual size does make more sense to display. We just need to clearly distinct between size (concrete hard size of a data structure) and virtual size (including other variables and attached to a bigger context).

I'm also not opposed to display multiple size types (at least base, total and virtual).

[laanwj]

Which size? We have:

• Base size
• Total size (base + witness)
• Virtual size (base + witness/4)
• Weight (4*base + witness)

I think the "easy to implement" tag was a bit deceptive in this case :) #8125 had no discussion about what size at all, I think everyone assumed it to be the size of gettransaction hex.

anyhow, utACK: Let's call it "Total size" and let people add other sizes later if they want.

[Cocosoft]

@laanwj Indeed, what seemed like an easy task blew up completely.
I can continue adding other types of sizes if we decide which ones to add.

anyhow, utACK: Let's call it "Total size" and let people add other sizes later if they want.

Will fix.

[MarcoFalke]

Please squash your commits according to https://github.com/bitcoin/bitcoin/blob/master/CONTRIBUTING.md#squashing-commits

[laanwj]

@MarcoFalke These are two logically separate commits, one adds the function, the other adds the information to the transaction description HTML, I don't think squashing is necessary.

ACK after the 'size'→ 'total size' disambiguation.

[fanquake]

It's pretty self explanatory, but here are some OS X screenshots.

[MarcoFalke]

utACK c015634

[paveljanik]

Please squash.

ACK c015634

[jonasschnelli]

Tested ACK c015634, merge-fixed size->total size.