Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[copyright] add MIT license headers to .sh scripts where missing #8700

Merged
merged 1 commit into from Sep 20, 2016

Conversation

Projects
None yet
8 participants
@isle2983
Copy link
Contributor

commented Sep 11, 2016

Adds a MIT license copyright header for 11 shell scripts (*.sh) in the repo.

Previous discussions of copyright headers are in PR #7300 and #8676. From those discussions, there is a perma-ACK on copyright headers from @MarcoFalke, so it can be assumed here.

So, for the files in this batch, we require an ACK from:

@sipa
@theuni
@jonasschnelli
@luke-jr
@runeksvendsen
@TheBlueMatt
@petertodd

Broken down by individual files:

contrib/devtools/git-subtree-check.sh (@sipa)
contrib/macdeploy/detached-sig-apply.sh (@theuni, @jonasschnelli)
contrib/macdeploy/detached-sig-create.sh (@theuni, @jonasschnelli)
contrib/macdeploy/extract-osx-sdk.sh (@luke-jr)
contrib/qos/tc.sh (@runeksvendsen)
contrib/tidy_datadir.sh (@sipa)
contrib/verify-commits/gpg.sh (@TheBlueMatt)
contrib/verify-commits/pre-push-hook.sh (@TheBlueMatt)
contrib/verify-commits/verify-commits.sh (@TheBlueMatt, @petertodd)
contrib/verifybinaries/verify.sh (@MarcoFalke)
src/qt/res/movies/makespinner.sh (@jonasschnelli, @MarcoFalke)

Like with #8646, after a few days, the files without ACK quorum will be removed and PR'd separately.

[copyright] add MIT license headers to .sh scripts where missing
Years are set according to 'git log' history

@fanquake fanquake added the Docs label Sep 12, 2016

@runeksvendsen

This comment has been minimized.

Copy link
Contributor

commented Sep 12, 2016

ACK

Also a perma-ACK from me to add the appropriate license header to all code I have contributed or will contribute to bitcoin/bitcoin.

@jonasschnelli

This comment has been minimized.

Copy link
Member

commented Sep 12, 2016

ACK

2 similar comments
@petertodd

This comment has been minimized.

Copy link
Contributor

commented Sep 13, 2016

ACK

@theuni

This comment has been minimized.

Copy link
Member

commented Sep 13, 2016

ACK

@MarcoFalke

This comment has been minimized.

Copy link
Member

commented Sep 19, 2016

ACK, I think this is ready.

@laanwj laanwj merged commit 0766d1c into bitcoin:master Sep 20, 2016

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

laanwj added a commit that referenced this pull request Sep 20, 2016

Merge #8700: [copyright] add MIT license headers to .sh scripts where…
… missing

0766d1c [copyright] add MIT license headers to .sh scripts where missing (isle2983)

luke-jr added a commit to luke-jr/bitcoin that referenced this pull request Sep 21, 2016

[copyright] add MIT license headers to .sh scripts where missing
Years are set according to 'git log' history

Github-Pull: bitcoin#8700
Rebased-From: 0766d1c

codablock added a commit to codablock/dash that referenced this pull request Jan 11, 2018

Merge bitcoin#8700: [copyright] add MIT license headers to .sh script…
…s where missing

0766d1c [copyright] add MIT license headers to .sh scripts where missing (isle2983)

andvgal added a commit to energicryptocurrency/energi that referenced this pull request Jan 6, 2019

Merge bitcoin#8700: [copyright] add MIT license headers to .sh script…
…s where missing

0766d1c [copyright] add MIT license headers to .sh scripts where missing (isle2983)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.