Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove old manpages from contrib/debian in favour of doc/man #8743

Merged
merged 1 commit into from Sep 25, 2016

Conversation

@fanquake
Copy link
Member

commented Sep 16, 2016

Removes the old manpages from contrib/debian/manpages, in favour of the newer ones in doc/man.
Also adds a note about updating the manpages to release-process.md

Pinging @TheBlueMatt, would you be able to look this look this over and point out any fixes.

Fixes #8711

@fanquake fanquake added the Docs label Sep 16, 2016

@MarcoFalke

This comment has been minimized.

Copy link
Member

commented Sep 16, 2016

utACK 365c0920e89635f0605a1e604f489b363538a987

contrib/debian/bitcoind.manpages Outdated
debian/manpages/bitcoin-cli.1
doc/man/bitcoind.1
doc/man/bitcoin-cli.1
doc/man/bitcoin-qt.1

This comment has been minimized.

Copy link
@TheBlueMatt

TheBlueMatt Sep 16, 2016

Contributor

This should be in a contrib/debian/bitcoin-qt.manpages (and similarly for bitcoin-tx)

contrib/debian/rules Outdated
@@ -6,7 +6,7 @@
# $(if $(filter nocheck,$(DEB_BUILD_OPTIONS)),,src/test_bitcoin)

DEB_INSTALL_EXAMPLES_bitcoind += debian/examples/*
DEB_INSTALL_MANPAGES_bitcoind += debian/manpages/*
DEB_INSTALL_MANPAGES_bitcoind += doc/man/*

This comment has been minimized.

Copy link
@TheBlueMatt

TheBlueMatt Sep 16, 2016

Contributor

Actually, these two lines should just be wholesale removed, I believe.

This comment has been minimized.

Copy link
@laanwj

laanwj Sep 22, 2016

Member

I think so too - make install installs the man pages, there's no need for debian to do anything special.

This comment has been minimized.

Copy link
@TheBlueMatt

TheBlueMatt Sep 22, 2016

Contributor

No, mostly this is a flag for a build method that we dont use - so these variables are just entirely ignored :).

@laanwj

This comment has been minimized.

Copy link
Member

commented Sep 20, 2016

utACK after fixing @TheBlueMatt's nits

@laanwj

This comment has been minimized.

Copy link
Member

commented Sep 22, 2016

@fanquake I've added a commit that fixes @TheBlueMatt 's comments. If this change is okay we should squash and merge this.

@laanwj laanwj force-pushed the fanquake:remove-old-manpages branch to b194872 Sep 25, 2016

@laanwj laanwj merged commit b194872 into bitcoin:master Sep 25, 2016

1 check was pending

continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
@laanwj laanwj referenced this pull request Sep 25, 2016
laanwj added a commit that referenced this pull request Sep 25, 2016
Merge #8743: Remove old manpages from contrib/debian in favour of doc…
…/man

b194872 Remove old manpages from contrib/debian (fanquake)
@fanquake

This comment has been minimized.

Copy link
Member Author

commented Sep 26, 2016

@laanwj Thanks for fixing this up, I haven't had access to push the changes.

@fanquake fanquake deleted the fanquake:remove-old-manpages branch Sep 26, 2016

codablock added a commit to codablock/dash that referenced this pull request Jan 23, 2018
Merge bitcoin#8743: Remove old manpages from contrib/debian in favour…
… of doc/man

b194872 Remove old manpages from contrib/debian (fanquake)
andvgal added a commit to energicryptocurrency/energi that referenced this pull request Jan 6, 2019
Merge bitcoin#8743: Remove old manpages from contrib/debian in favour…
… of doc/man

b194872 Remove old manpages from contrib/debian (fanquake)
CryptoCentric added a commit to absolute-community/absolute that referenced this pull request Feb 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.