New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Doc] Add missing autogen to example builds #8787
Conversation
configure comes with the source code packages. You should not be using git unless you are a developer. |
But in practice most people following this guide seem to be cloning from git. No one uses the source tarball. It's mostly developers that follow this guide in the first place. Also IIRC we mention It could ofc. be added that it is optional. |
@luke-jr I always build from git but I am a developer and thought the document was intended for developers. If not, then please close my PR but like @laanwj points out, build-osx.md and build-unix.md reference the autogen.sh step. Maybe I can add an |
Maybe just add a comment after it |
@@ -27,15 +27,15 @@ To build executables for Windows 32-bit: | |||
cd depends | |||
make HOST=i686-w64-mingw32 -j4 | |||
cd .. | |||
./configure --prefix=`pwd`/depends/i686-w64-mingw32 | |||
./autogen.sh && ./configure --prefix=`pwd`/depends/i686-w64-mingw32 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Agree with @laanwj
Is it okay like this?
If you agree, I will make the change and squash into one commit. |
I made the corrections and squashed my commits. |
3f58a28 [Doc] Add missing autogen to example builds (Amir Abrams)
3f58a28 [Doc] Add missing autogen to example builds (Amir Abrams)
3f58a28 [Doc] Add missing autogen to example builds (Amir Abrams)
The Windows cross-compile build examples are missing the
autogen.sh
step. Without that step,configure
doesn't exist and you get this error:Using Ubuntu 16.04 64 bit.