Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Doc] Add missing autogen to example builds #8787

Merged
merged 1 commit into from Sep 25, 2016
Merged

[Doc] Add missing autogen to example builds #8787

merged 1 commit into from Sep 25, 2016

Conversation

AmirAbrams
Copy link
Contributor

The Windows cross-compile build examples are missing the autogen.sh step. Without that step, configure doesn't exist and you get this error:

bash: ./configure: No such file or directory

Using Ubuntu 16.04 64 bit.

@laanwj laanwj added the Docs label Sep 22, 2016
@laanwj
Copy link
Member

laanwj commented Sep 22, 2016

ACK.

Using Ubuntu 16.04 64 bit.

If you are cross-compiling from Ubuntu 16.04 I'd suggest reading #8732 #8653 #8730 #8511, there are serious current compatibility issues.

@luke-jr
Copy link
Member

luke-jr commented Sep 22, 2016

configure comes with the source code packages. You should not be using git unless you are a developer.

@laanwj
Copy link
Member

laanwj commented Sep 22, 2016

But in practice most people following this guide seem to be cloning from git. No one uses the source tarball. It's mostly developers that follow this guide in the first place. Also IIRC we mention autogen.sh in all other places (such as build-unix.md).

It could ofc. be added that it is optional.

@AmirAbrams
Copy link
Contributor Author

@luke-jr I always build from git but I am a developer and thought the document was intended for developers. If not, then please close my PR but like @laanwj points out, build-osx.md and build-unix.md reference the autogen.sh step. Maybe I can add an if/fi that checks for the configure file or explain the example is for source code packages?

@laanwj
Copy link
Member

laanwj commented Sep 22, 2016

Maybe I can add an if/fi that checks for the configure file or explain the example is for source code packages?

Maybe just add a comment after it # not required when building from tarball. Adding a fi/if construction sounds like overkill, and anyhow this is based on information only the user can know.

@@ -27,15 +27,15 @@ To build executables for Windows 32-bit:
cd depends
make HOST=i686-w64-mingw32 -j4
cd ..
./configure --prefix=`pwd`/depends/i686-w64-mingw32
./autogen.sh && ./configure --prefix=`pwd`/depends/i686-w64-mingw32
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agree with @laanwj

@AmirAbrams
Copy link
Contributor Author

AmirAbrams commented Sep 22, 2016

Is it okay like this?

cd ..
./autogen.sh # not required when building from tarball
./configure --prefix=`pwd`/depends/i686-w64-mingw32

If you agree, I will make the change and squash into one commit.

@AmirAbrams
Copy link
Contributor Author

I made the corrections and squashed my commits.

@laanwj laanwj merged commit 3f58a28 into bitcoin:master Sep 25, 2016
laanwj added a commit that referenced this pull request Sep 25, 2016
3f58a28 [Doc] Add missing autogen to example builds (Amir Abrams)
codablock pushed a commit to codablock/dash that referenced this pull request Jan 11, 2018
3f58a28 [Doc] Add missing autogen to example builds (Amir Abrams)
andvgal pushed a commit to energicryptocurrency/gen2-energi that referenced this pull request Jan 6, 2019
3f58a28 [Doc] Add missing autogen to example builds (Amir Abrams)
@bitcoin bitcoin locked as resolved and limited conversation to collaborators Sep 8, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants