Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[qa] fix nulldummy test #8841

Merged
merged 1 commit into from Sep 30, 2016

Conversation

@jl2012
Copy link
Contributor

commented Sep 29, 2016

Sorry that I just find a minor bug in the test. msg is used to indicate that the transaction should be rejected. However, before this fix, even if the tx was accepted with a non-empty msg, the test would still pass.

@laanwj laanwj added the Tests label Sep 29, 2016

@MarcoFalke MarcoFalke added this to the 0.13.1 milestone Sep 29, 2016

qa/rpc-tests/nulldummy.py Outdated
@@ -119,6 +119,9 @@ def tx_submit(self, node, tx, msg = ""):
node.sendrawtransaction(bytes_to_hex_str(tx.serialize_with_witness()), True)
except JSONRPCException as exp:
assert_equal(exp.error["message"], msg)
else:
if (msg):
assert(False)

This comment has been minimized.

Copy link
@MarcoFalke

MarcoFalke Sep 29, 2016

Member

To print the message on failure, what about something like

assert_equal('', msg)

This comment has been minimized.

Copy link
@jl2012

jl2012 Sep 29, 2016

Author Contributor

revise as suggested. Thanks

@jl2012 jl2012 force-pushed the jl2012:nulldummytest branch Sep 29, 2016

@jl2012 jl2012 force-pushed the jl2012:nulldummytest branch to 46a4774 Sep 29, 2016

@MarcoFalke

This comment has been minimized.

Copy link
Member

commented Sep 29, 2016

utACK 46a4774

@laanwj laanwj merged commit 46a4774 into bitcoin:master Sep 30, 2016

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
laanwj added a commit that referenced this pull request Sep 30, 2016
Merge #8841: [qa] fix nulldummy test
46a4774 Fix nulldummy.py test (Johnson Lau)
MarcoFalke added a commit to MarcoFalke/bitcoin that referenced this pull request Oct 3, 2016
Fix nulldummy.py test
Github-Pull: bitcoin#8841
Rebased-From: 46a4774
codablock added a commit to codablock/dash that referenced this pull request Jan 30, 2018
Merge bitcoin#8841: [qa] fix nulldummy test
46a4774 Fix nulldummy.py test (Johnson Lau)
andvgal added a commit to energicryptocurrency/energi that referenced this pull request Jan 6, 2019
Merge bitcoin#8841: [qa] fix nulldummy test
46a4774 Fix nulldummy.py test (Johnson Lau)
CryptoCentric added a commit to absolute-community/absolute that referenced this pull request Feb 28, 2019
Merge bitcoin#8841: [qa] fix nulldummy test
46a4774 Fix nulldummy.py test (Johnson Lau)
CryptoCentric added a commit to absolute-community/absolute that referenced this pull request Mar 2, 2019
Merge bitcoin#8841: [qa] fix nulldummy test
46a4774 Fix nulldummy.py test (Johnson Lau)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.