Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add copyright/patent issues to possible NACK reasons #8915

Merged

Conversation

@petertodd
Copy link
Contributor

commented Oct 13, 2016

Adding in response to a Slack discussion where someone was unclear on the fact that a NACK may be justified if code can't be accepted due to copyright/patent issues. For example, it would be reasonable and prudent to NACK a contribution of AGPL-licensed consensus code on the basis that the license terms are incompatible with the MIT license used by the rest of the codebase.

@fanquake fanquake added the Docs label Oct 13, 2016

CONTRIBUTING.md Outdated
@@ -178,7 +178,9 @@ language is used within pull-request comments:

- ACK means "I have tested the code and I agree it should be merged";
- NACK means "I disagree this should be merged", and must be accompanied by
sound technical justification. NACKs without accompanying reasoning may be disregarded;
sound technical justification (or in certain cases of copyright/patent

This comment has been minimized.

Copy link
@btcdrak

btcdrak Oct 13, 2016

Member

add /licensing because patches may also be unable to be included if the licensing is incompatible with the project.

This comment has been minimized.

Copy link
@petertodd

petertodd Oct 13, 2016

Author Contributor

fixed

Add copyright/patent issues to possible NACK reasons
Adding in response to a Slack discussion where someone was unclear on the fact
that a NACK may be justified if code can't be accepted due to copyright/patent
issues.  For example, it would be reasonable and prudent to NACK a contribution
of AGPL-licensed consensus code on the basis that the license terms are
incompatible with the MIT license used by the rest of the codebase.

@petertodd petertodd force-pushed the petertodd:2016-10-13-sound-legal-justification branch to 36f60a5 Oct 13, 2016

@laanwj

This comment has been minimized.

Copy link
Member

commented Oct 13, 2016

utACK

2 similar comments
@btcdrak

This comment has been minimized.

Copy link
Member

commented Oct 13, 2016

utACK

@fanquake

This comment has been minimized.

Copy link
Member

commented Oct 14, 2016

utACK

@MarcoFalke MarcoFalke merged commit 36f60a5 into bitcoin:master Oct 14, 2016

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
MarcoFalke added a commit that referenced this pull request Oct 14, 2016
Merge #8915: Add copyright/patent issues to possible NACK reasons
36f60a5 Add copyright/patent issues to possible NACK reasons (Peter Todd)

@petertodd petertodd deleted the petertodd:2016-10-13-sound-legal-justification branch Oct 14, 2016

codablock added a commit to codablock/dash that referenced this pull request Jan 12, 2018
Merge bitcoin#8915: Add copyright/patent issues to possible NACK reasons
36f60a5 Add copyright/patent issues to possible NACK reasons (Peter Todd)
andvgal added a commit to energicryptocurrency/energi that referenced this pull request Jan 6, 2019
Merge bitcoin#8915: Add copyright/patent issues to possible NACK reasons
36f60a5 Add copyright/patent issues to possible NACK reasons (Peter Todd)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants
You can’t perform that action at this time.