/bitcoin

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Qt: Add "Copy URI" to payment request context menu #8918

Merged
merged 1 commit into from Oct 18, 2016

Conversation

Reviewers
No reviews
Assignees
No one assigned
Labels
GUI
Projects
None yet
Milestone
No milestone
4 participants
@luke-jr @laanwj @jonasschnelli @fanquake
@luke-jr
Member

luke-jr commented Oct 13, 2016

Rationale: I find myself sometimes needing to get the address for a payment again, and doing so by double-clicking to open the request dialog to copy it. Putting it right there on the context menu seems reasonable. (I am adding Copy URI instead of Copy Address because in the future payment requests might not use addresses.)

@fanquake fanquake added the GUI label Oct 14, 2016

@laanwj
Owner

laanwj commented Oct 15, 2016

Concept ACK
@jonasschnelli
Member

jonasschnelli commented Oct 17, 2016

Concept ACK.
I understand the point of "Copy URI", but wouldn't "Copy Address/URI" be more appropriate until BIP70 has broader usage?
@luke-jr
Member

luke-jr commented Oct 17, 2016

I don't understand the question. "Copy URI" works today for all payment requests (address or BIP70) and is supported by pretty much every wallet.
@laanwj
Owner

laanwj commented Oct 17, 2016 •
Edited 1 time

wouldn't "Copy Address/URI" be more appropriate until BIP70 has broader usage?

It always copies an URI right? If so, we should not make the message longer and more complex.
@jonasschnelli
Member

jonasschnelli commented Oct 18, 2016

It always copies an URI right? If so, we should not make the message longer and more complex.

Right. I was confused.

Tested ACK 21f5a63

@laanwj laanwj merged commit 21f5a63 into bitcoin:master Oct 18, 2016
1 check passed

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

laanwj added a commit that referenced this pull request Oct 18, 2016

@laanwj
Merge #8918: Qt: Add "Copy URI" to payment request context menu 
21f5a63 Qt: Add "Copy URI" to payment request context menu (Luke Dashjr)
This commit was signed with a verified signature.
@laanwj laanwj Wladimir J. van der Laan
GPG key ID: 74810B012346C9A6 Learn about signing commits
47ace42

codablock added a commit to codablock/dash that referenced this pull request Sep 7, 2017

@laanwj @codablock
Merge #8918: Qt: Add "Copy URI" to payment request context menu 
21f5a63 Qt: Add "Copy URI" to payment request context menu (Luke Dashjr)
e726e19

UdjinM6 added a commit to dashpay/dash that referenced this pull request Sep 9, 2017

@codablock @UdjinM6
Backport Bitcoin Qt/Gui changes up to 0.14.x part 2 (#1615) 
* Merge #7506: Use CCoinControl selection in CWallet::FundTransaction

d6cc6a1 Use CCoinControl selection in CWallet::FundTransaction (João Barbosa)

* Merge #7732: [Qt] Debug window: replace "Build date" with "Datadir"

fc737d1 [Qt] remove unused formatBuildDate method (Jonas Schnelli)
4856f1d [Qt] Debug window: replace "Build date" with "Datadir" (Jonas Schnelli)

* Merge #7707: [RPC][QT] UI support for abandoned transactions

8efed3b [Qt] Support for abandoned/abandoning transactions (Jonas Schnelli)

* Merge #7688: List solvability in listunspent output and improve help

c3932b3 List solvability in listunspent output and improve help (Pieter Wuille)

* Merge #8006: Qt: Add option to disable the system tray icon

8b0e497 Qt: Add option to hide the system tray icon (Tyler Hardin)

* Merge #8073: qt: askpassphrasedialog: Clear pass fields on accept

02ce2a3 qt: askpassphrasedialog: Clear pass fields on accept (Pavel Vasin)

* Merge #8231: [Qt] fix a bug where the SplashScreen will not be hidden during startup

b3e1348 [Qt] fix a bug where the SplashScreen will not be hidden during startup (Jonas Schnelli)

* Merge #8257: Do not ask a UI question from bitcoind

1acf1db Do not ask a UI question from bitcoind (Pieter Wuille)

* Merge #8463: [qt] Remove Priority from coincontrol dialog

fa8dd78 [qt] Remove Priority from coincontrol dialog (MarcoFalke)

* Merge #8678: [Qt][CoinControl] fix UI bug that could result in paying unexpected fee

0480293 [Qt][CoinControl] fix UI bug that could result in paying unexpected fee (Jonas Schnelli)

* Merge #8672: Qt: Show transaction size in transaction details window

c015634 qt: Adding transaction size to transaction details window (Hampus Sjöberg)
 \-- merge fix for s/size/total size/
fdf82fb Adding method GetTotalSize() to CTransaction (Hampus Sjöberg)

* Merge #8371: [Qt] Add out-of-sync modal info layer

08827df [Qt] modalinfolayer: removed unused comments, renamed signal, code style overhaul (Jonas Schnelli)
d8b062e [Qt] only update "amount of blocks left" when the header chain is in-sync (Jonas Schnelli)
e3245b4 [Qt] add out-of-sync modal info layer (Jonas Schnelli)
e47052f [Qt] ClientModel add method to get the height of the header chain (Jonas Schnelli)
a001f18 [Qt] Always pass the numBlocksChanged signal for headers tip changed (Jonas Schnelli)
bd44a04 [Qt] make Out-Of-Sync warning icon clickable (Jonas Schnelli)
0904c3c [Refactor] refactor function that forms human readable text out of a timeoffset (Jonas Schnelli)

* Merge #8805: Trivial: Grammar and capitalization

c9ce17b Trivial: Grammar and capitalization (Derek Miller)

* Merge #8885: gui: fix ban from qt console

cb78c60 gui: fix ban from qt console (Cory Fields)

* Merge #8821: [qt] sync-overlay: Don't block during reindex

fa85e86 [qt] sync-overlay: Don't show estimated number of headers left (MarcoFalke)
faa4de2 [qt] sync-overlay: Don't block during reindex (MarcoFalke)

* Support themes for new transaction_abandoned icon

* Fix constructor call to COutput

* Merge #7842: RPC: do not print minping time in getpeerinfo when no ping received yet

62a6486 RPC: do not print ping info in getpeerinfo when no ping received yet, fix help (Pavel Janík)

* Merge #8918: Qt: Add "Copy URI" to payment request context menu

21f5a63 Qt: Add "Copy URI" to payment request context menu (Luke Dashjr)

* Merge #8925: qt: Display minimum ping in debug window.

1724a40 Display minimum ping in debug window. (R E Broadley)

* Merge #8972: [Qt] make warnings label selectable (jonasschnelli)

ef0c9ee [Qt] make warnings label selectable (Jonas Schnelli)

* Make background of warning icon transparent in modaloverlay

* Merge #9088: Reduce ambiguity of warning message

77cbbd9 Make warning message about wallet balance possibly being incorrect less ambiguous. (R E Broadley)

* Replace Bitcoin with Dash in modal overlay

* Remove clicked signals from labelWalletStatus and labelTransactionsStatus

As both are really just labels, clicking on those is not possible.
This is different in Bitcoin, where these labels are actually buttons.

* Pull out modaloverlay show/hide into it's own if/else block and switch to time based check

Also don't use masternodeSync.IsBlockchainSynced() for now as it won't
report the blockchain being synced before the first block (or other MN
data?) arrives. This would otherwise give the impression that sync is
being stuck.
9707ca5
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment