Qt: Add "Copy URI" to payment request context menu #8918

Merged
merged 1 commit into from Oct 18, 2016

Projects

None yet

4 participants

@luke-jr
Member
luke-jr commented Oct 13, 2016

Rationale: I find myself sometimes needing to get the address for a payment again, and doing so by double-clicking to open the request dialog to copy it. Putting it right there on the context menu seems reasonable. (I am adding Copy URI instead of Copy Address because in the future payment requests might not use addresses.)

@fanquake fanquake added the GUI label Oct 14, 2016
@laanwj
Member
laanwj commented Oct 15, 2016

Concept ACK

@jonasschnelli
Member

Concept ACK.
I understand the point of "Copy URI", but wouldn't "Copy Address/URI" be more appropriate until BIP70 has broader usage?

@luke-jr
Member
luke-jr commented Oct 17, 2016

I don't understand the question. "Copy URI" works today for all payment requests (address or BIP70) and is supported by pretty much every wallet.

@laanwj
Member
laanwj commented Oct 17, 2016 edited

wouldn't "Copy Address/URI" be more appropriate until BIP70 has broader usage?

It always copies an URI right? If so, we should not make the message longer and more complex.

@jonasschnelli
Member

It always copies an URI right? If so, we should not make the message longer and more complex.

Right. I was confused.

Tested ACK 21f5a63

@laanwj laanwj merged commit 21f5a63 into bitcoin:master Oct 18, 2016

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@laanwj laanwj added a commit that referenced this pull request Oct 18, 2016
@laanwj laanwj Merge #8918: Qt: Add "Copy URI" to payment request context menu
21f5a63 Qt: Add "Copy URI" to payment request context menu (Luke Dashjr)
47ace42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment