qt: Display minimum ping in debug window. #8925

Merged
merged 1 commit into from Oct 18, 2016

Projects

None yet

5 participants

@rebroad
Contributor
rebroad commented Oct 15, 2016

Adds minimum ping to the debug information, and replaces the last ping with the minimum ping in the node list.

@paveljanik
Contributor

Why replacing? Isn't the last ping time more valuable? Why renaming the member variable?

@rebroad
Contributor
rebroad commented Oct 16, 2016

@paveljanik Good questions, which perhaps I ought to have proactively explained.

Minimum ping is used in disconnection logic for evicting incoming connections, so a way it is the more relevant value.

Renaming the variable so that it is consistent with the RPC variable.

@MarcoFalke
Member

utACK 1724a40

@MarcoFalke MarcoFalke changed the title from Display minimum ping in debug window. to qt: Display minimum ping in debug window. Oct 16, 2016
@paveljanik
Contributor

ACK 1724a40

@jonasschnelli
Member

Yes. Why not.
utACK 1724a40

@laanwj laanwj merged commit 1724a40 into bitcoin:master Oct 18, 2016

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@laanwj laanwj added a commit that referenced this pull request Oct 18, 2016
@laanwj laanwj Merge #8925: qt: Display minimum ping in debug window.
1724a40 Display minimum ping in debug window. (R E Broadley)
f628d9a
@luke-jr luke-jr added a commit to bitcoinknots/bitcoin that referenced this pull request Dec 21, 2016
@rebroad @luke-jr rebroad + luke-jr Partial: Display minimum ping in debug window.
Github-Pull: #8925
Rebased-From-Partially: 1724a40
9667f76
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment