Join GitHub today
GitHub is home to over 20 million developers working together to host and review code, manage projects, and build software together.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
Already on GitHub? Sign in to your account
Enable pubkey lookup for p2sh-p2wpkh in validateaddress #8992
Conversation
| + CPubKey vchPubKey; | ||
| + if (pwalletMain->GetPubKey(CKeyID(uint160(witnessprogram)), vchPubKey)) { | ||
| + obj.push_back(Pair("pubkey", HexStr(vchPubKey))); | ||
| + obj.push_back(Pair("iscompressed", vchPubKey.IsCompressed())); |
jl2012
Oct 21, 2016
Member
Signing and watching with segwit uncompressed keys are already disabled. I think the results should be suppressed if the key is not compressed.
fanquake
added
the
RPC/REST/ZMQ
label
Oct 22, 2016
|
@jl2012 suppressed uncompressed pubkeys and removed the |
instagibbs
referenced this pull request
Oct 25, 2016
Closed
Enable various p2sh-p2wpkh functionality #9017
added a commit
to bitcoinknots/bitcoin
that referenced
this pull request
Dec 21, 2016
added a commit
to bitcoinknots/bitcoin
that referenced
this pull request
Dec 21, 2016
|
Closing in favor of #9017 |
instagibbs
closed this
Jan 4, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
instagibbs commentedOct 21, 2016
When we ever switch to p2sh-p2pkh this will be useful for general wallet usage, as well as adapting tests where retrieving the pubkeys for standard addresses is important.