Add missing cs_main lock to ::GETBLOCKTXN processing #8995

Merged
merged 1 commit into from Oct 24, 2016

Projects

None yet

5 participants

@TheBlueMatt
Contributor

Note that this is not a major issue as, in order for the missing
lock to cause issues, you have to receive a GETBLOCKTXN message
while reindexing, adding a block header via RPC, etc, which results
in either a table rehash or an insert into the bucket which you are
currently looking at.

@TheBlueMatt TheBlueMatt Add missing cs_main lock to ::GETBLOCKTXN processing
Note that this is not a major issue as, in order for the missing
lock to cause issues, you have to receive a GETBLOCKTXN message
while reindexing, adding a block header via RPC, etc, which results
in either a table rehash or an insert into the bucket which you are
currently looking at.
dfe7906
@sipa sipa added this to the 0.13.1 milestone Oct 23, 2016
@jonasschnelli jonasschnelli added the P2P label Oct 23, 2016
@sipa
Member
sipa commented Oct 23, 2016

utACK dfe7906

@laanwj laanwj merged commit dfe7906 into bitcoin:master Oct 24, 2016

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@laanwj laanwj added a commit that referenced this pull request Oct 24, 2016
@laanwj laanwj Merge #8995: Add missing cs_main lock to ::GETBLOCKTXN processing
dfe7906 Add missing cs_main lock to ::GETBLOCKTXN processing (Matt Corallo)
ced22d0
@theuni
Member
theuni commented Oct 24, 2016

post-merge utACK.

@laanwj laanwj added a commit to laanwj/bitcoin that referenced this pull request Oct 25, 2016
@TheBlueMatt @laanwj TheBlueMatt + laanwj Add missing cs_main lock to ::GETBLOCKTXN processing
Note that this is not a major issue as, in order for the missing
lock to cause issues, you have to receive a GETBLOCKTXN message
while reindexing, adding a block header via RPC, etc, which results
in either a table rehash or an insert into the bucket which you are
currently looking at.

Github-Pull: #8995
Rebased-From: dfe7906
a587f8a
@laanwj laanwj added a commit to laanwj/bitcoin that referenced this pull request Oct 27, 2016
@TheBlueMatt @laanwj TheBlueMatt + laanwj Add missing cs_main lock to ::GETBLOCKTXN processing
Note that this is not a major issue as, in order for the missing
lock to cause issues, you have to receive a GETBLOCKTXN message
while reindexing, adding a block header via RPC, etc, which results
in either a table rehash or an insert into the bucket which you are
currently looking at.

Github-Pull: #8995
Rebased-From: dfe7906
9ef3875
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment