keypoololdest denote Unix epoch, not GMT #9041

Merged
merged 1 commit into from Oct 31, 2016

Projects

None yet

3 participants

@s-matthew-english
Contributor

keypoololdest is seconds since Unix epoch, not "GMT epoch" as was previously written

Resources:
https://bitcointalk.org/index.php?topic=4451.0
http://bitcoin.stackexchange.com/questions/35913/what-does-the-keypoololdest-field-mean

@MarcoFalke
Member

@s-matthew-english Did you know you can use $ git grep keypoololdest to see if there are other affected rpcs, so all of them can be fixed in one go?

@s-matthew-english
Contributor

ahh, yeah I mean, I knew of 'grep' but I didn't use it before really. at the moment I'm tied up, but definetly later tonight I can and will do that, but- if you don't mind, could I try to do it myself so I can get some experience with that?

@s-matthew-english
Contributor

alright, great!

I've grepped for 'GMT epoch' and I spotted another one in "src/wallet/rpcwallet.cpp", so now I've changed that one too.

I commited everything according to that discussion we had last time so- I think I did it right. Is it so?

@MarcoFalke
Member

utACK 7f61b49, I think both describe the same thing, but it can't hurt...

@sipa
Member
sipa commented Oct 31, 2016

They do mean the same thing, but I think that Unix epoch is less ambiguous.

@MarcoFalke MarcoFalke merged commit 7f61b49 into bitcoin:master Oct 31, 2016

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@MarcoFalke MarcoFalke added a commit that referenced this pull request Oct 31, 2016
@MarcoFalke MarcoFalke Merge #9041: keypoololdest denote Unix epoch, not GMT
7f61b49 Change all instance of 'GMT epoch' to 'Unix epoch' (matthias)
3d69ecb
@luke-jr luke-jr added a commit to luke-jr/bitcoin that referenced this pull request Dec 2, 2016
@s-matthew-english @luke-jr s-matthew-english + luke-jr Change all instance of 'GMT epoch' to 'Unix epoch'
Github-Pull: #9041
Rebased-From: 7f61b49
87fbced
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment