/bitcoin

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

[qa] Rework sync_* and preciousblock.py #9097

Merged
merged 2 commits into from Nov 10, 2016

Conversation

Reviewers
No reviews
Assignees
No one assigned
Labels
Refactoring Tests
Projects
None yet
Milestone
No milestone
2 participants
@MarcoFalke @jtimon
@MarcoFalke
Member

MarcoFalke commented Nov 7, 2016

preciousblock.py:

  • Use assert_equal(), so failures are more verbose
  • Also some trivial refactoring

sync_*():

  • Only allow named args and add timeout to sync_chain()
  • Make failures more verbose

@MarcoFalke MarcoFalke added the Tests label Nov 7, 2016

@MarcoFalke
[qa] util: Rework sync_*() 
* Only allow named args in sync_*()
* Make sync_* fails more verbose
* Add timeout to sync_chain()
fa97ccb

@MarcoFalke MarcoFalke added the Refactoring label Nov 7, 2016

@jtimon
Member

jtimon commented Nov 7, 2016

Concept ACK

@MarcoFalke MarcoFalke merged commit fa97ccb into bitcoin:master Nov 10, 2016
1 check passed

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

MarcoFalke added a commit that referenced this pull request Nov 10, 2016

@MarcoFalke
Merge #9097: [qa] Rework sync_* and preciousblock.py 
fa97ccb [qa] util: Rework sync_*() (MarcoFalke)
fac1141 [qa] preciousblock: Use assert_equal and BitcoinTestFramework.__init__ (MarcoFalke)
This commit was signed with a verified signature.
@MarcoFalke MarcoFalke
GPG key ID: 2D7F2372E50FE137 Learn about signing commits
e536499

@MarcoFalke MarcoFalke deleted the MarcoFalke:Mf1611-qaSyncAndPrecious branch Nov 10, 2016

luke-jr added a commit to bitcoinknots/bitcoin that referenced this pull request Dec 21, 2016

@MarcoFalke @luke-jr
[qa] preciousblock: Use assert_equal and BitcoinTestFramework.__init__ 
Github-Pull: #9097
Rebased-From: fac1141
f52b8b6
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment