Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[depends] Set OSX_MIN_VERSION to 10.8 #9114

Merged
merged 1 commit into from Nov 11, 2016

Conversation

@fanquake
Copy link
Member

commented Nov 9, 2016

0.13.0 is no longer compatible with OS X 10.7, see discussion in this thread, and a plist change was made to prevent bitcoin-core running on 10.7 systems.

Earlier discussion mentioned that once we set the minimum target version to 10.8, we could remove some OS X related hacks, particularly in macnotificationhandler.mm, so that could now be revisited.

@laanwj

This comment has been minimized.

Copy link
Member

commented Nov 9, 2016

Concept ACK

@jonasschnelli

This comment has been minimized.

Copy link
Member

commented Nov 9, 2016

ACK 617c96d

@paveljanik

This comment has been minimized.

Copy link
Contributor

commented Nov 9, 2016

Concept ACK

@theuni

This comment has been minimized.

Copy link
Member

commented Nov 10, 2016

utACK 617c96d

@fanquake

This comment has been minimized.

Copy link
Member Author

commented Nov 11, 2016

A bit more info about this. If you generate a depends prefix on OS X 10.12, and then plug that into configure, ./configure --prefix=/Users/michael/Github/bitcoin/depends/x86_64-apple-darwin16.1.0, when you compile it will fail with:

In file included from httpserver.cpp:22:
/Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/../include/c++/v1/future:1162:1: error: 'future<bool>' is unavailable: introduced in macOS 10.8
future<_Rp>::~future()

/Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/../include/c++/v1/future:1896:1: error: '__packaged_task_function<bool (event_base *, evhttp *)>' is unavailable: introduced in macOS 10.8
__packaged_task_function<_Rp(_ArgTypes...)>::__packaged_task_function(_Fp&& __f)

/Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/../include/c++/v1/future:632:1: error: '__assoc_state<bool>' is unavailable: introduced in macOS 10.8
__assoc_state<_Rp>::__on_zero_shared() _NOEXCEPT

/Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/../include/c++/v1/future:1455:1: error: 'promise<bool>' is unavailable: introduced in macOS 10.8
promise<_Rp>::get_future()

18 errors generated.

After this change it compiles.

@laanwj laanwj merged commit 617c96d into bitcoin:master Nov 11, 2016

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
laanwj added a commit that referenced this pull request Nov 11, 2016
Merge #9114: [depends] Set OSX_MIN_VERSION to 10.8
617c96d [depends] Set OSX_MIN_VERSION to 10.8 (fanquake)

@fanquake fanquake deleted the fanquake:depends-min-osx-10-8 branch Nov 11, 2016

@str4d str4d referenced this pull request Oct 29, 2017
zkbot added a commit to zcash/zcash that referenced this pull request Nov 29, 2017
Auto merge of #2697 - str4d:darwin-build, r=<try>
Darwin build fixes

Includes fixes cherry-picked from the following upstream PRs:

- bitcoin/bitcoin#7136
  - Only the third commit (to avoid a merge conflict)
- bitcoin/bitcoin#7302
  - Excluding the first commit, which is unnecessary (we use Boost 1.62)
- bitcoin/bitcoin#7487
- bitcoin/bitcoin#7606
- bitcoin/bitcoin#7711
- bitcoin/bitcoin#7165
- bitcoin/bitcoin#8002
- bitcoin/bitcoin#8210
  - Only the second commit
- bitcoin/bitcoin#9114
zkbot added a commit to zcash/zcash that referenced this pull request Nov 30, 2017
Auto merge of #2697 - str4d:darwin-build, r=<try>
Darwin build fixes

Includes fixes cherry-picked from the following upstream PRs:

- bitcoin/bitcoin#7136
  - Only the third commit (to avoid a merge conflict)
- bitcoin/bitcoin#7302
  - Excluding the first commit, which is unnecessary (we use Boost 1.62)
- bitcoin/bitcoin#7487
- bitcoin/bitcoin#7606
- bitcoin/bitcoin#7711
- bitcoin/bitcoin#7165
- bitcoin/bitcoin#8002
- bitcoin/bitcoin#8210
  - Only the second commit
- bitcoin/bitcoin#9114
zkbot added a commit to zcash/zcash that referenced this pull request Nov 30, 2017
Auto merge of #2697 - str4d:darwin-build, r=str4d
Darwin build fixes

Includes fixes cherry-picked from the following upstream PRs:

- bitcoin/bitcoin#7136
  - Only the third commit (to avoid a merge conflict)
- bitcoin/bitcoin#7302
  - Excluding the first commit, which is unnecessary (we use Boost 1.62)
- bitcoin/bitcoin#7487
- bitcoin/bitcoin#7606
- bitcoin/bitcoin#7711
- bitcoin/bitcoin#7165
- bitcoin/bitcoin#8002
- bitcoin/bitcoin#8210
  - Only the second commit
- bitcoin/bitcoin#9114
zkbot added a commit to zcash/zcash that referenced this pull request Nov 30, 2017
Auto merge of #2697 - str4d:darwin-build, r=str4d
Darwin build fixes

Includes fixes cherry-picked from the following upstream PRs:

- bitcoin/bitcoin#7136
  - Only the third commit (to avoid a merge conflict)
- bitcoin/bitcoin#7302
  - Excluding the first commit, which is unnecessary (we use Boost 1.62)
- bitcoin/bitcoin#7487
- bitcoin/bitcoin#7606
- bitcoin/bitcoin#7711
- bitcoin/bitcoin#7165
- bitcoin/bitcoin#8002
- bitcoin/bitcoin#8210
  - Only the second commit
- bitcoin/bitcoin#9114
codablock added a commit to codablock/dash that referenced this pull request Feb 7, 2018
Merge bitcoin#9114: [depends] Set OSX_MIN_VERSION to 10.8
617c96d [depends] Set OSX_MIN_VERSION to 10.8 (fanquake)
@sickpig sickpig referenced this pull request Jun 5, 2018
CryptoCentric added a commit to absolute-community/absolute that referenced this pull request Feb 28, 2019
Merge bitcoin#9114: [depends] Set OSX_MIN_VERSION to 10.8
617c96d [depends] Set OSX_MIN_VERSION to 10.8 (fanquake)
CryptoCentric added a commit to absolute-community/absolute that referenced this pull request Mar 2, 2019
Merge bitcoin#9114: [depends] Set OSX_MIN_VERSION to 10.8
617c96d [depends] Set OSX_MIN_VERSION to 10.8 (fanquake)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants
You can’t perform that action at this time.