Join GitHub today
GitHub is home to over 20 million developers working together to host and review code, manage projects, and build software together.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
Already on GitHub? Sign in to your account
Mention the new network toggle functionality in the tooltip. #9130
Conversation
|
". |
fanquake
added
the
GUI
label
Nov 11, 2016
|
Nice! I think the standalone "." is okay. |
|
s/Press/Click/? |
|
utACK 45e0dca. What happens if you replace the br with a single space? |
|
@luke-jr Click, because it is not a button. Yes. Changed. @MarcoFalke Without br, the tooltip is three lines long and the break is in the middle of a sentence. It looked really bad thus I have copied the solution used for other long tooltips. First line is info, second line is the help what to do next/description. |
| } else { | ||
| - connectionsControl->setToolTip(tr("Network activity disabled")); | ||
| + tooltip = tr("Network activity disabled") + QString(".<br>") + tr("Click to enable network activity again."); |
luke-jr
Nov 12, 2016
•
Member
I believe this is a new string, so prefer to put the period in the translation. (keep the <br> outside however)
|
@luke-jr Right! So this can be even more nicer. Will do in an hour or so. |
|
Ready for review. |
|
utACK 1260c11 |
|
utACK 1260c11 |
|
utACK 1260c11 |
MarcoFalke
assigned
jonasschnelli
Nov 18, 2016
jonasschnelli
merged commit 1260c11
into
bitcoin:master
Nov 22, 2016
1 check passed
added a commit
that referenced
this pull request
Nov 22, 2016
|
@jonasschnelli Does anyone else think its a bit too easy to actually turn off your whole network. I think this tooltip will help a bit, but it seems a pretty benign thing to just click on that little network symbol and you don't realize you're disconnecting yourself from the network. Would it be better (or possible) to give you a little drop down or a confirmation or something? |
|
@morcos: No strong opinion. Maybe a confirmation dialog could make sense. Though, maybe only at the first time, otherwise this will annoy experience users. |
|
Agree that the feature is hidden. Also, I think we don't need to prevent accidental disconnects, as the cross mark is shown clearly, so the user can figure out what happened pretty fast. |
|
What about making cross mark red? |
|
Just as a data point -- I was surprised by this behavior a couple days ago when I clicked on that network icon (before this tooltip was added) and unexpectedly disconnected from the network. I thought it was surprising that of the 4 icons in the bottom corner, 2 of them can be clicked on to do something while 2 don't do anything, and of those that do something, 1 gives a dropdown (the one for changing units) while 1 just does something immediately (disconnect the network). |
|
Maybe we should at a warning bar at the top, similar to the "prerelease
software" one, that says "You are currently disconnected from the network,
click [here] or on the network icon in the status bar to re-enable"?
|
|
Three ideas were mentioned before:
|
|
Maybe clicking the icon should give a context menu with disconnect and network settings (open the options dialog to the right tab)? |
paveljanik commentedNov 11, 2016
As requested by @jonasschnelli at #8996 (comment), add a tooltip: