Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Mention the new network toggle functionality in the tooltip. #9130

Merged
merged 1 commit into from Nov 22, 2016

Conversation

Projects
None yet
9 participants
Contributor

paveljanik commented Nov 11, 2016

As requested by @jonasschnelli at #8996 (comment), add a tooltip:

screen shot 2016-11-11 at 11 56 11

screen shot 2016-11-11 at 11 56 17

Contributor

paveljanik commented Nov 11, 2016

".
" to save translators work... But ugly 8)

@fanquake fanquake added the GUI label Nov 11, 2016

Member

jonasschnelli commented Nov 11, 2016

Nice!
utACK 45e0dca

I think the standalone "." is okay.

Member

luke-jr commented Nov 11, 2016

s/Press/Click/?

Member

MarcoFalke commented Nov 11, 2016

utACK 45e0dca. What happens if you replace the br with a single space?

Contributor

paveljanik commented Nov 11, 2016

@luke-jr Click, because it is not a button. Yes. Changed.

@MarcoFalke Without br, the tooltip is three lines long and the break is in the middle of a sentence. It looked really bad thus I have copied the solution used for other long tooltips. First line is info, second line is the help what to do next/description.

src/qt/bitcoingui.cpp
} else {
- connectionsControl->setToolTip(tr("Network activity disabled"));
+ tooltip = tr("Network activity disabled") + QString(".<br>") + tr("Click to enable network activity again.");
@luke-jr

luke-jr Nov 12, 2016

Member

I believe this is a new string, so prefer to put the period in the translation. (keep the <br> outside however)

@paveljanik

paveljanik Nov 12, 2016

Contributor

@luke-jr Pardon? What is a new string?

@luke-jr

luke-jr Nov 12, 2016

Member

"Network activity disabled" has not been in any Core releases yet.

Contributor

paveljanik commented Nov 12, 2016

@luke-jr Right! So this can be even more nicer. Will do in an hour or so.

Contributor

paveljanik commented Nov 17, 2016

Ready for review.

Owner

laanwj commented Nov 17, 2016

utACK 1260c11

Member

MarcoFalke commented Nov 17, 2016

utACK 1260c11

Member

fanquake commented Nov 18, 2016

utACK 1260c11

@jonasschnelli jonasschnelli merged commit 1260c11 into bitcoin:master Nov 22, 2016

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

jonasschnelli added a commit that referenced this pull request Nov 22, 2016

Merge #9130: Mention the new network toggle functionality in the tool…
…tip.


1260c11 Mention the new network toggle functionality in the tooltip. (Pavel Janík)
Member

morcos commented Nov 22, 2016

@jonasschnelli Does anyone else think its a bit too easy to actually turn off your whole network. I think this tooltip will help a bit, but it seems a pretty benign thing to just click on that little network symbol and you don't realize you're disconnecting yourself from the network. Would it be better (or possible) to give you a little drop down or a confirmation or something?

@sdaftuar?

Member

jonasschnelli commented Nov 22, 2016

@morcos: No strong opinion. Maybe a confirmation dialog could make sense. Though, maybe only at the first time, otherwise this will annoy experience users.
At the moment, the feature is relatively hidden.

Member

MarcoFalke commented Nov 22, 2016

Agree that the feature is hidden. Also, I think we don't need to prevent accidental disconnects, as the cross mark is shown clearly, so the user can figure out what happened pretty fast.

Contributor

paveljanik commented Nov 23, 2016

What about making cross mark red?

Member

sdaftuar commented Nov 23, 2016

Just as a data point -- I was surprised by this behavior a couple days ago when I clicked on that network icon (before this tooltip was added) and unexpectedly disconnected from the network. I thought it was surprising that of the 4 icons in the bottom corner, 2 of them can be clicked on to do something while 2 don't do anything, and of those that do something, 1 gives a dropdown (the one for changing units) while 1 just does something immediately (disconnect the network).

Owner

sipa commented Nov 23, 2016

Contributor

paveljanik commented Nov 23, 2016

Three ideas were mentioned before:

  • slide overlay (as in initial sync phase)

  • confirm first "Disable network" click

  • make cross red

Member

luke-jr commented Nov 23, 2016

Maybe clicking the icon should give a context menu with disconnect and network settings (open the options dialog to the right tab)?

luke-jr added a commit to bitcoinknots/bitcoin that referenced this pull request Dec 21, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment