[qt] Make network disabled icon 50% opaque #9145

Merged
merged 1 commit into from Nov 14, 2016

Projects

None yet

5 participants

@MarcoFalke
Member

The png was sampled too low, so displayed incorrectly on high res displays. Also, I modified the alpha channel a bit.

@MarcoFalke MarcoFalke added the GUI label Nov 12, 2016
@MarcoFalke MarcoFalke added this to the 0.14.0 milestone Nov 12, 2016
src/qt/res/src/network_disabled.svg
@@ -5,11 +5,11 @@
xmlns:rdf="http://www.w3.org/1999/02/22-rdf-syntax-ns#"
xmlns:svg="http://www.w3.org/2000/svg"
xmlns="http://www.w3.org/2000/svg"
- id="svg2"
@paveljanik
paveljanik Nov 12, 2016 Contributor

isn't this only re-sorted?

@MarcoFalke
MarcoFalke Nov 12, 2016 Member

Inkscape did this.

@luke-jr
luke-jr Nov 12, 2016 Member

So don't use Inkscape...?

@MarcoFalke
MarcoFalke Nov 13, 2016 Member

Fixed sorting nit

src/qt/res/src/network_disabled.svg
width="24"
- version="1.2">
+ height="24"
@luke-jr
luke-jr Nov 12, 2016 Member

The size of the SVG isn't changed...

@MarcoFalke
MarcoFalke Nov 13, 2016 edited Member

This is not required. You can tell the program of your choice what dpi to sample at.

Nonetheless, I changed it to 92 for this svg, as well as for all connect-$N.svg

@jonasschnelli
Member

utACK fa30b06

SVG's XML is interpreted and created differently. No need for bikeshedding there.

@Victorsueca

ACK fa30b06
Tested on Windows x64
GUI Screenshot

@paveljanik
Contributor

Nice and reviewable now 👍
ACK fa42e4a

@jonasschnelli jonasschnelli merged commit fa42e4a into bitcoin:master Nov 14, 2016

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@jonasschnelli jonasschnelli added a commit that referenced this pull request Nov 14, 2016
@jonasschnelli jonasschnelli Merge #9145: [qt] Make network disabled icon 50% opaque
fa42e4a [qt] Make network disabled icon 50% opaque (MarcoFalke)
924745d
@paveljanik
Contributor

Thanks to both Marco and Luke!

@MarcoFalke MarcoFalke deleted the MarcoFalke:Mf1611-qtNetworkIcon branch Nov 14, 2016
@luke-jr luke-jr added a commit to bitcoinknots/bitcoin that referenced this pull request Dec 21, 2016
@MarcoFalke @luke-jr MarcoFalke + luke-jr [qt] Make network disabled icon 50% opaque
Github-Pull: #9145
Rebased-From: fa42e4a
58e922e
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment