Make orphan parent fetching ask for witnesses. #9188

Merged
merged 1 commit into from Dec 1, 2016

Projects

None yet

8 participants

@gmaxwell
Member

In 0.13 orphan transactions began being treated as implicit
INVs for their parents. But the resulting getdata were
not getting the witness flag.

This fixes issue #9182 reported by chjj and roasbeef on IRC.

@gmaxwell gmaxwell Make orphan parent fetching ask for witnesses.
In 0.13 orphan transactions began being treated as implicit
 INVs for their parents.  But the resulting getdata were
 not getting the witness flag.

This fixes issue #9182 reported by chjj and roasbeef on IRC.
5b0150a
@gmaxwell
Member

This should be tagged for backport.

@instagibbs
Contributor

utACK 5b0150a

@sdaftuar
Contributor

utACK 5b0150a

@sipa sipa added this to the 0.13.2 milestone Nov 18, 2016
@morcos
Contributor
morcos commented Nov 21, 2016

utACK

@sipa
Member
sipa commented Nov 22, 2016

utACK

@btcdrak
Member
btcdrak commented Nov 22, 2016

utACK

@morcos
Contributor
morcos commented Dec 1, 2016

tested ACK

@laanwj ready for merge

@sipa sipa merged commit 5b0150a into bitcoin:master Dec 1, 2016

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@sipa sipa added a commit that referenced this pull request Dec 1, 2016
@sipa sipa Merge #9188: Make orphan parent fetching ask for witnesses.
5b0150a Make orphan parent fetching ask for witnesses. (Gregory Maxwell)
ad826b3
@laanwj laanwj added a commit to laanwj/bitcoin that referenced this pull request Dec 2, 2016
@gmaxwell @laanwj gmaxwell + laanwj Make orphan parent fetching ask for witnesses.
In 0.13 orphan transactions began being treated as implicit
 INVs for their parents.  But the resulting getdata were
 not getting the witness flag.

This fixes issue #9182 reported by chjj and roasbeef on IRC.

Github-Pull: #9188
Rebased-From: 5b0150a
65a0770
@laanwj laanwj referenced this pull request Dec 2, 2016
Merged

0.13.2 backports #9264

@laanwj
Member
laanwj commented Dec 2, 2016

Backported in #9264, removing tag.

@laanwj laanwj removed the Needs backport label Dec 2, 2016
@laanwj laanwj added a commit to laanwj/bitcoin that referenced this pull request Dec 2, 2016
@gmaxwell @laanwj gmaxwell + laanwj Make orphan parent fetching ask for witnesses.
In 0.13 orphan transactions began being treated as implicit
 INVs for their parents.  But the resulting getdata were
 not getting the witness flag.

This fixes issue #9182 reported by chjj and roasbeef on IRC.

Github-Pull: #9188
Rebased-From: 5b0150a
ca1fd75
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment