Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix some benign races #9225

Merged
merged 5 commits into from Nov 29, 2016

Conversation

@TheBlueMatt
Copy link
Contributor

commented Nov 26, 2016

This fixes some benign races reported by helgrind. It makes some things atomic that need it, and fixes locking in addrman so that some log statements cant print garbage.

@morcos

This comment has been minimized.

Copy link
Member

commented Nov 27, 2016

Thanks! The fDisconnect race was bothering me.

utACK

@gmaxwell

This comment has been minimized.

Copy link
Contributor

commented Nov 29, 2016

utACK. All looks good to me.

@laanwj

This comment has been minimized.

Copy link
Member

commented Nov 29, 2016

utACK dfed983

@laanwj laanwj merged commit dfed983 into bitcoin:master Nov 29, 2016

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
laanwj added a commit that referenced this pull request Nov 29, 2016
Merge #9225: Fix some benign races
dfed983 Fix unlocked access to vNodes.size() (Matt Corallo)
3033522 Remove double brackets in addrman (Matt Corallo)
dbfaade Fix AddrMan locking (Matt Corallo)
047ea10 Make fImporting an std::atomic (Matt Corallo)
42071ca Make fDisconnect an std::atomic (Matt Corallo)
codablock added a commit to codablock/dash that referenced this pull request Jan 17, 2018
Merge bitcoin#9225: Fix some benign races
dfed983 Fix unlocked access to vNodes.size() (Matt Corallo)
3033522 Remove double brackets in addrman (Matt Corallo)
dbfaade Fix AddrMan locking (Matt Corallo)
047ea10 Make fImporting an std::atomic (Matt Corallo)
42071ca Make fDisconnect an std::atomic (Matt Corallo)
@dagurval dagurval referenced this pull request Jun 8, 2018
andvgal added a commit to energicryptocurrency/energi that referenced this pull request Jan 6, 2019
Merge bitcoin#9225: Fix some benign races
dfed983 Fix unlocked access to vNodes.size() (Matt Corallo)
3033522 Remove double brackets in addrman (Matt Corallo)
dbfaade Fix AddrMan locking (Matt Corallo)
047ea10 Make fImporting an std::atomic (Matt Corallo)
42071ca Make fDisconnect an std::atomic (Matt Corallo)
CryptoCentric added a commit to absolute-community/absolute that referenced this pull request Feb 25, 2019
Merge bitcoin#9225: Fix some benign races
dfed983 Fix unlocked access to vNodes.size() (Matt Corallo)
3033522 Remove double brackets in addrman (Matt Corallo)
dbfaade Fix AddrMan locking (Matt Corallo)
047ea10 Make fImporting an std::atomic (Matt Corallo)
42071ca Make fDisconnect an std::atomic (Matt Corallo)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants
You can’t perform that action at this time.