torcontrol: Explicitly request RSA1024 private key #9234

Merged
merged 1 commit into from Nov 30, 2016

Projects

None yet

8 participants

@laanwj
Member
laanwj commented Nov 28, 2016

When generating a new service key, explicitly request a RSA1024 one.

The bitcoin P2P protocol has no support for the longer hidden service names that will come with ed25519 keys, until it does, we depend on the old hidden service type so make this explicit.

See #9214.

@laanwj laanwj added this to the 0.13.2 milestone Nov 28, 2016
@laanwj laanwj torcontrol: Explicitly request RSA1024 private key
When generating a new service key, explicitly request a RSA1024 one.

The bitcoin P2P protocol has no support for the longer hidden service names
that will come with ed25519 keys, until it does, we depend on the old
hidden service type so make this explicit.

See #9214.
7d3b627
@btcdrak
Member
btcdrak commented Nov 28, 2016

utACK

@sipa
Member
sipa commented Nov 28, 2016

utACK 7d3b627

@fanquake
Contributor

utACK 7d3b627

@paveljanik
Contributor

utACK 7d3b627

@gmaxwell
Member

utACK; do we know how far back tor version wise this is supported?

@laanwj
Member
laanwj commented Nov 29, 2016
@laanwj
Member
laanwj commented Nov 29, 2016

The parameter is documented here: https://gitweb.torproject.org/torspec.git/tree/control-spec.txt#n1446

There is no mention of any version constraints relevant to KeyBlob.

@gits7r
gits7r commented Nov 29, 2016

ACK.

I confirm explicitly asking for the key type is supported for as far back as ADD_ONION is. Until RSA1024 keys (v2 HS) are permanently rejected in the Tor network, this patch should work. It's useless to ask for BEST key type when there is a p2p protocol 'address' limitation (I don't think the limit should go away, just increased just enough to keep up with current demands).

@gmaxwell
Member
gmaxwell commented Nov 30, 2016 edited

ACK. (tested now)

@laanwj laanwj merged commit 7d3b627 into bitcoin:master Nov 30, 2016

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@laanwj laanwj added a commit that referenced this pull request Nov 30, 2016
@laanwj laanwj Merge #9234: torcontrol: Explicitly request RSA1024 private key
7d3b627 torcontrol: Explicitly request RSA1024 private key (Wladimir J. van der Laan)
56bee49
@laanwj laanwj added a commit that referenced this pull request Nov 30, 2016
@laanwj laanwj torcontrol: Explicitly request RSA1024 private key
When generating a new service key, explicitly request a RSA1024 one.

The bitcoin P2P protocol has no support for the longer hidden service names
that will come with ed25519 keys, until it does, we depend on the old
hidden service type so make this explicit.

See #9214.

Rebased-From: 7d3b627
Github-Pull: #9234
94531b5
@MarcoFalke MarcoFalke added a commit to MarcoFalke/bitcoin that referenced this pull request Nov 30, 2016
@laanwj @MarcoFalke laanwj + MarcoFalke torcontrol: Explicitly request RSA1024 private key
When generating a new service key, explicitly request a RSA1024 one.

The bitcoin P2P protocol has no support for the longer hidden service names
that will come with ed25519 keys, until it does, we depend on the old
hidden service type so make this explicit.

See #9214.

Github-Pull: #9234
Rebased-From: 7d3b627
82e29e8
@MarcoFalke
Member

Was backported to 0.13 in 94531b5. (Removing label)

Added backport for 0.12 to #9211

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment