Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix calculation of number of bound sockets to use #9253

Merged
merged 1 commit into from Dec 1, 2016

Conversation

@TheBlueMatt
Copy link
Contributor

commented Dec 1, 2016

Pulled this out of #9243 because it is a logically separate change.

@sipa

This comment has been minimized.

Copy link
Member

commented Dec 1, 2016

utACK 9e1f468

@laanwj

This comment has been minimized.

Copy link
Member

commented Dec 1, 2016

utACK 9e1f468

@paveljanik

This comment has been minimized.

Copy link
Contributor

commented Dec 1, 2016

What is returned by mapMultiArgs.at("-bind").size() if !mapMultiArgs.count("-bind")? Do we need the condition at all?
Edit: answering to myself: std::out_of_range exception is thrown.

@sipa

This comment has been minimized.

Copy link
Member

commented Dec 1, 2016

@paveljanik It would raise an exception. Using [] instead would result in adding "-bind" as a key to the map.

@paveljanik

This comment has been minimized.

Copy link
Contributor

commented Dec 1, 2016

ACK 9e1f468

@jonasschnelli

This comment has been minimized.

Copy link
Member

commented Dec 1, 2016

utACK 9e1f468

@gmaxwell

This comment has been minimized.

Copy link
Contributor

commented Dec 1, 2016

utACK

@instagibbs

This comment has been minimized.

Copy link
Member

commented Dec 1, 2016

utACK 9e1f468

@morcos

This comment has been minimized.

Copy link
Member

commented Dec 1, 2016

utACK

@laanwj ready for merge

@sipa sipa merged commit 9e1f468 into bitcoin:master Dec 1, 2016
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
sipa added a commit that referenced this pull request Dec 1, 2016
9e1f468 Fix calculation of number of bound sockets to use (Matt Corallo)
luke-jr added a commit to luke-jr/bitcoin that referenced this pull request Dec 2, 2016
@laanwj laanwj added the P2P label Dec 19, 2016
codablock added a commit to codablock/dash that referenced this pull request Jan 17, 2018
9e1f468 Fix calculation of number of bound sockets to use (Matt Corallo)
lateminer added a commit to lateminer/bitcoin that referenced this pull request Oct 24, 2018
andvgal added a commit to energicryptocurrency/energi that referenced this pull request Jan 6, 2019
9e1f468 Fix calculation of number of bound sockets to use (Matt Corallo)
CryptoCentric added a commit to absolute-community/absolute that referenced this pull request Feb 25, 2019
9e1f468 Fix calculation of number of bound sockets to use (Matt Corallo)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
9 participants
You can’t perform that action at this time.