Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[qa] Use cached utxo set to fix performance regression #9274

Merged
merged 2 commits into from Dec 6, 2016
Merged

[qa] Use cached utxo set to fix performance regression #9274

merged 2 commits into from Dec 6, 2016

Conversation

maflcko
Copy link
Member

@maflcko maflcko commented Dec 4, 2016

I removed the caching in #9221, which made pruning take longer.

Credit goes to @morcos for quickly raising the issue: #9221 (comment)

@maflcko maflcko added the Tests label Dec 4, 2016
@maflcko maflcko added this to the 0.14.0 milestone Dec 4, 2016
@maflcko maflcko self-assigned this Dec 4, 2016
@morcos
Copy link
Member

morcos commented Dec 4, 2016

what about fixing maxuploadtarget.py
i think it also got slower?

@maflcko
Copy link
Member Author

maflcko commented Dec 4, 2016

Not as significant, but gives back about 10 seconds, why not.

@maflcko maflcko changed the title [qa] pruning: Use cached utxo set to run faster [qa] Use cached utxo set to fix performance regression Dec 5, 2016
@morcos
Copy link
Member

morcos commented Dec 5, 2016

ACK

Thanks.

@maflcko maflcko merged commit fab1af3 into bitcoin:master Dec 6, 2016
maflcko pushed a commit that referenced this pull request Dec 6, 2016
Merge #9274: [qa] Use cached utxo set to fix performance regression
919db03 
fab1af3 [qa] maxuploadtarget: Use cached utxo set (MarcoFalke)
fa2ecc4 [qa] pruning: Use cached utxo set to run faster (MarcoFalke)
@maflcko maflcko deleted the Mf1612-qaPruningCacheUtxos branch December 6, 2016 11:09
codablock pushed a commit to codablock/dash that referenced this pull request Jan 17, 2018
@codablock
Merge bitcoin#9274: [qa] Use cached utxo set to fix performance regre…
19958fe 
…ssion

fab1af3 [qa] maxuploadtarget: Use cached utxo set (MarcoFalke)
fa2ecc4 [qa] pruning: Use cached utxo set to run faster (MarcoFalke)
@dagurval dagurval mentioned this pull request Feb 20, 2018
Merged
@sickpig sickpig mentioned this pull request May 28, 2018
Merged
andvgal pushed a commit to energicryptocurrency/gen2-energi that referenced this pull request Jan 6, 2019
@andvgal
Merge bitcoin#9274: [qa] Use cached utxo set to fix performance regre…
dafda43 
…ssion

fab1af3 [qa] maxuploadtarget: Use cached utxo set (MarcoFalke)
fa2ecc4 [qa] pruning: Use cached utxo set to run faster (MarcoFalke)
CryptoCentric pushed a commit to absolute-community/absolute that referenced this pull request Feb 25, 2019
@CryptoCentric
Merge bitcoin#9274: [qa] Use cached utxo set to fix performance regre…
4f6119c 
…ssion

fab1af3 [qa] maxuploadtarget: Use cached utxo set (MarcoFalke)
fa2ecc4 [qa] pruning: Use cached utxo set to run faster (MarcoFalke)
@bitcoin bitcoin locked as resolved and limited conversation to collaborators Sep 8, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees

@maflcko maflcko

Labels
Tests
Projects
None yet
Milestone
0.14.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@maflcko @morcos