Add test for -walletrejectlongchains #9395
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Tests? |
|
As the |
|
@dcousens ok test added |
|
Awesome, thanks @morcos |
instagibbs
approved these changes
Dec 21, 2016
| self.nodes[0] = start_node(0, self.options.tmpdir, ["-walletrejectlongchains", "-limitancestorcount="+str(2*chainlimit)]) | ||
|
|
||
| # wait for loadmempool | ||
| timeout = 10 |
There was a problem hiding this comment.
oops thanks.. adding the update of timeout
|
utACK |
|
utACK 2f882f8 |
jonasschnelli
approved these changes
Dec 21, 2016
|
ACK-before-it-was-conflicted needs rebase. |
|
This was fixed in #9283, but still is useful to add the test, so kept that commit . (and changed PR title) |
morcos
changed the title
|
re-ACK ffeb195 |
maflcko
pushed a commit
that referenced
this pull request
Jan 4, 2017
ffeb195 add test for -walletrejectlongchains (Alex Morcos)
codablock
pushed a commit
to codablock/dash
that referenced
this pull request
Jan 18, 2018
ffeb195 add test for -walletrejectlongchains (Alex Morcos)
andvgal
pushed a commit
to energicryptocurrency/gen2-energi
that referenced
this pull request
Jan 6, 2019
ffeb195 add test for -walletrejectlongchains (Alex Morcos)
CryptoCentric
pushed a commit
to absolute-community/absolute
that referenced
this pull request
Feb 26, 2019
ffeb195 add test for -walletrejectlongchains (Alex Morcos)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
txNewwas moved from to createwtxNewso we don't really mean to be accessing it afterwards.The current code is not actually calculating mempool ancestors so
-walletrejectlongchainsis not having any effect.