Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor mempool.dat to be extensible, and store missing info #9422

Closed
wants to merge 2 commits into from

Conversation

@luke-jr
Copy link
Member

luke-jr commented Dec 25, 2016

Should fix #9103

src/validation.cpp Show resolved Hide resolved
@paveljanik
Copy link
Contributor

paveljanik commented Jan 8, 2017

Needs rebase.

src/validation.cpp Show resolved Hide resolved
src/validation.cpp Outdated Show resolved Hide resolved
src/validation.cpp Outdated Show resolved Hide resolved
@luke-jr
Copy link
Member Author

luke-jr commented Jan 12, 2017

Fixed serialisation params. There are conflicts now - may I rebase?

@luke-jr luke-jr force-pushed the luke-jr:mempool_dat_extensible branch Jan 12, 2017
@luke-jr
Copy link
Member Author

luke-jr commented Jan 12, 2017

Rebased.

@luke-jr luke-jr force-pushed the luke-jr:mempool_dat_extensible branch 2 times, most recently to b14300f Feb 2, 2017
Copy link
Member

kallewoof left a comment

utACK b14300f

@@ -4192,42 +4192,63 @@ bool LoadMempool(void)
if (version != MEMPOOL_DUMP_VERSION) {

This comment has been minimized.

Copy link
@kallewoof

kallewoof Feb 10, 2017

Member

The implications seem to be minor, but this means all bitcoin nodes prior to this PR being merged will drop all their mempools on startup. Is that okay? Would it be possible / worth it to load version=1 mempools too? Above comment by @sipa seems to indicate this was never used, in which case I think we should simply say MEMPOOL_DUMP_VERSION = 1 above.

@luke-jr luke-jr force-pushed the luke-jr:mempool_dat_extensible branch from b14300f to 5d25b27 Aug 23, 2017
@luke-jr luke-jr force-pushed the luke-jr:mempool_dat_extensible branch from 5d25b27 to 8d309b8 Sep 3, 2017
Copy link
Contributor

TheBlueMatt left a comment

I'm not actually sure we want to save mempoolminfee - if you just restarted the practical mempoolminfee on the network may be much lower....it puts you in a state of downloading lots of transactions only pretty briefly (assuming any of your peers aren't limiting their mempool, which they almost always are, so mempoolminfee on most nodes never actually leaves 0 anyway). Probably not worth a incompatible version just for this, IMO, though if we had other things we wanted to store we could revisit.

@sipa
Copy link
Member

sipa commented Mar 6, 2018

I'm not sure this is worth it right now; we can revisit if there is critical information to add to the mempool file?

@luke-jr luke-jr force-pushed the luke-jr:mempool_dat_extensible branch from 8d309b8 to 1d34442 Mar 6, 2018
@laanwj
Copy link
Member

laanwj commented May 14, 2018

Thee seems to be no agreement to do this right now.
I'm also going to close #9103, we shouldn't have that issue open if we don't agree that this should be done.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

8 participants
You can’t perform that action at this time.