Join GitHub today
GitHub is home to over 20 million developers working together to host and review code, manage projects, and build software together.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
Already on GitHub? Sign in to your account
[Qt] Show more significant warning if we fall back to the default fee #9481
Conversation
jonasschnelli
added
the
GUI
label
Jan 6, 2017
| @@ -760,10 +760,30 @@ | ||
| </layout> | ||
| </item> | ||
| + <item> | ||
| + <widget class="QLabel" name="fallbackFeeWarningLabel"> | ||
| + <property name="toolTip"> | ||
| + <string>Using the fallbackfee can result in sending a transaction that will take serval hours or days (or never) to confirm. Consider choosing your fee manually or wait until your have validated the complete chain.</string> |
MarcoFalke
Jan 6, 2017
Member
validating the whole chain is not enough. You also need the mempool at all times of validation.
jonasschnelli
Jan 6, 2017
Member
I have though about that, but to not over-explain this, I was picking out the most important part, which is probably a validated chain. And since we persist the mempool, this is less of a problem.
| @@ -760,10 +760,30 @@ | ||
| </layout> | ||
| </item> | ||
| + <item> | ||
| + <widget class="QLabel" name="fallbackFeeWarningLabel"> | ||
| + <property name="toolTip"> | ||
| + <string>Using the fallbackfee can result in sending a transaction that will take serval hours or days (or never) to confirm. Consider choosing your fee manually or wait until your have validated the complete chain.</string> |
MarcoFalke
Jan 6, 2017
Member
Maybe just mention that the fallbackfee is hardcoded and the fee should be selected manually. (or the node should be run for some hours to initialize smart fee)
|
Concept ACK |
| @@ -760,10 +760,30 @@ | ||
| </layout> | ||
| </item> | ||
| + <item> | ||
| + <widget class="QLabel" name="fallbackFeeWarningLabel"> | ||
| + <property name="toolTip"> | ||
| + <string>Using the fallbackfee can result in sending a transaction that will take serval hours or days (or never) to confirm. Consider choosing your fee manually or wait until your have validated the complete chain.</string> |
|
Fixed the text after recommendation from @paveljanik and @MarcoFalke. |
|
Concept ACK I think there are a few other things we could potentially do:
It's always going to be problem to get transactions out the door before we've had a chance to bootstrap fee estimation but would be nice to make it harder for users to shoot themselves in the foot. At least now the fallbackfee is such that their transactions will probably be confirmed within a day or two, but that might not remain true... In any case, warning with the current behavior is a good first step. |
|
@morcos to your list: get bumpfee working really well and worry less about this. :) |
| + <string>Using the static fallback-fee can result in sending a transaction that will take several hours or days (or never) to confirm or that you overpay the fees. Consider choosing your fee manually or wait until your have validated the complete chain.</string> | ||
| + </property> | ||
| + <property name="styleSheet"> | ||
| + <string notr="true">color: rgb(255, 150, 0); |
luke-jr
Feb 9, 2017
Member
This affects the tooltip style as well. Additionally, it is hard to read on some styles.
|
This is an excellent idea, thanks for implementing it. Concept ACK! |
|
Actually, this seems redundant with Edit: (Oh, nevermind. That's not visible by default.) |
luke-jr
added some commits
Feb 17, 2017
|
Worksforme. ACK 7abe7bb: |
laanwj
merged commit 7abe7bb
into
bitcoin:master
Mar 14, 2017
1 check passed
added a commit
that referenced
this pull request
Mar 14, 2017
practicalswift
referenced this pull request
Mar 16, 2017
Merged
[trivial] Fix a typo (introduced two days ago) in the default fee warning #10008
|
I found a typo in this PR - see #10008 for details. Sorry for not catching it pre-merge :-) |
added a commit
to luke-jr/bitcoin
that referenced
this pull request
Jun 5, 2017
added a commit
to luke-jr/bitcoin
that referenced
this pull request
Jun 5, 2017
added a commit
to luke-jr/bitcoin
that referenced
this pull request
Jun 5, 2017
jonasschnelli commentedJan 6, 2017
There are multiple reports (bitcoin.stackoverflow, etc.) from users sending (very-)low-fee-transactions with bitcoin-core.
The reason for this is probably that some users are not waiting long enough until smartfee estimation is possible.
The current fallback fee is
0.0002BTC/kb, one of my ~0.13.0 nodes is telling me0.00069534for a confirmation target of 25 blocks. Using the current fallback fee can be troublesome.If we have to use the fallback-ferrate, we should probably warn the user more significant (there is no "warning" right now.).
Screenshots:
