/bitcoin

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

[Qt][RPC] Autocomplete commands for 'help' command in debug console #9500

Merged
merged 1 commit into from Mar 23, 2017
+3 −0

Conversation

Reviewers

@jonasschnelli jonasschnelli

Assignees
No one assigned
Labels
RPC/REST/ZMQ
Projects
None yet
Milestone
No milestone
7 participants
@achow101 @jonasschnelli @sipa @MarcoFalke @paveljanik @kallewoof @fanquake
@achow101
Member

achow101 commented Jan 10, 2017

Puts the commands in the autocompletion box when doing a help <command> command in the debug console.
@achow101
'help' rpc commands autocomplete 
Adds autocompletion of the commands for when getting the help of a command by using `help <command>`
6d8fe35

@fanquake fanquake added the RPC/REST/ZMQ label Jan 10, 2017

@jonasschnelli
Member

jonasschnelli commented Jan 10, 2017

Nice. Concept ACK. Will test soon.
@jonasschnelli

jonasschnelli approved these changes Jan 10, 2017
View changes

tested ACK 6d8fe35

bildschirmfoto 2017-01-10 um 17 09 26

@sipa
Owner

sipa commented Jan 10, 2017

Neat. Concept ACk
@MarcoFalke
Member

MarcoFalke commented Jan 10, 2017

@paveljanik
Contributor

paveljanik commented Jan 10, 2017

ACK 6d8fe35
@kallewoof
Member

kallewoof commented Feb 28, 2017

ACK 6d8fe35
@fanquake
Member

fanquake commented Mar 22, 2017

Tested 6d8fe35 on OS X. Appears as below:
screen shot 1
screen shot 2

@jonasschnelli jonasschnelli merged commit 6d8fe35 into bitcoin:master Mar 23, 2017
1 check passed

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

jonasschnelli added a commit that referenced this pull request Mar 23, 2017

@jonasschnelli
Merge #9500: [Qt][RPC] Autocomplete commands for 'help' command in de… 
…bug console


6d8fe35 'help' rpc commands autocomplete (Andrew Chow)

Tree-SHA512: 289bc4fa16a1c0291262998caa18556f1c5aa89662c85528606dc03b596b8833a0fb2c5c9c068b6dcf2adb3a136d4f154591d4a95b8c3313638b77355aaed955
This commit was signed with a verified signature.
@jonasschnelli jonasschnelli Jonas Schnelli
GPG key ID: 1EB776BB03C7922D Learn about signing commits
3568b30

@achow101 achow101 deleted the achow101:help-rpc-autocomplete branch Apr 5, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment