[RPC] dumpmasterprivkey command #9504
Conversation
|
|
|
|
There was a problem hiding this comment.
Not sure if we should add more private key exporting features because it increases the risk of doing something wrong with that.
If we are going to add this, it would require...
... add dumpmasterprivkey to the UI's sensitiv data filter
... add a test somewhere
src/wallet/rpcwallet.cpp
Outdated
| @@ -2602,6 +2603,7 @@ static const CRPCCommand commands[] = | |||
| { "wallet", "addwitnessaddress", &addwitnessaddress, true, {"address"} }, | |||
| { "wallet", "backupwallet", &backupwallet, true, {"destination"} }, | |||
| { "wallet", "dumpprivkey", &dumpprivkey, true, {"address"} }, | |||
| { "wallet", "dumpmasterprivkey", &dumpmasterprivkey, true, {} }, | |||
There was a problem hiding this comment.
nit: column alignment.
src/wallet/rpcdump.cpp
Outdated
|
|
||
| EnsureWalletIsUnlocked(); | ||
|
|
||
| CKeyID masterKeyID = pwalletMain->GetHDChain().masterKeyID; |
There was a problem hiding this comment.
Use CWallet::IsHDEnabled()?
There was a problem hiding this comment.
Well,... you need the masterKeys CKeyID anyway,... but I guess it would still make sense to use CWallet::IsHDEnabled()
|
@jonasschnelli there is no sensitive data filter for the |
achow101
force-pushed
the
dumpmasterprivkey
branch
from
e86eb43
to
4589ad3
Compare
|
Addressed nits and added a test. It may need more tests, but I'm not sure what actually needs to be tested. |
achow101
force-pushed
the
dumpmasterprivkey
branch
from
4589ad3
to
342a564
Compare
Argh. Right. I was confusing the sensitiv history filter with the idea of having a filter that disables certain sensitive commands. |
achow101
force-pushed
the
dumpmasterprivkey
branch
2 times, most recently
from
c74e66b
to
dfa8648
Compare
RPC command to export the master private key from a wallet.
achow101
force-pushed
the
dumpmasterprivkey
branch
from
dfa8648
to
07fc811
Compare
|
Closing this for now |
RPC command to export the master private key from a wallet.