[RPC] dumpmasterprivkey command

[achow101]

RPC command to export the master private key from a wallet.

[luke-jr]

dumpwallet already does this...?

[achow101]

dumpwallet requires that you dump to a file then find that file and open it to get the master private key. This just gives it to you with the command.

[jonasschnelli]

Not sure if we should add more private key exporting features because it increases the risk of doing something wrong with that.

If we are going to add this, it would require...
... add dumpmasterprivkey to the UI's sensitiv data filter
... add a test somewhere

[jonasschnelli]

nit: column alignment.

[jonasschnelli]

Use CWallet::IsHDEnabled()?

[jonasschnelli]

Well,... you need the masterKeys CKeyID anyway,... but I guess it would still make sense to use CWallet::IsHDEnabled()

[achow101]

@jonasschnelli there is no sensitive data filter for the dump* commands. The user is not entering sensitive data, only sensitive data being output.

[achow101]

Addressed nits and added a test.

It may need more tests, but I'm not sure what actually needs to be tested.

[jonasschnelli]

@jonasschnelli there is no sensitive data filter for the dump* commands. The user is not entering sensitive data, only sensitive data being output.

Argh. Right. I was confusing the sensitiv history filter with the idea of having a filter that disables certain sensitive commands.

[achow101]

Closing this for now