Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RPC] dumpmasterprivkey command #9504

Closed
wants to merge 1 commit into from

Conversation

@achow101
Copy link
Member

achow101 commented Jan 10, 2017

RPC command to export the master private key from a wallet.

@luke-jr
Copy link
Member

luke-jr commented Jan 10, 2017

dumpwallet already does this...?

@achow101
Copy link
Member Author

achow101 commented Jan 10, 2017

dumpwallet requires that you dump to a file then find that file and open it to get the master private key. This just gives it to you with the command.

Copy link
Member

jonasschnelli left a comment

Not sure if we should add more private key exporting features because it increases the risk of doing something wrong with that.

If we are going to add this, it would require...
... add dumpmasterprivkey to the UI's sensitiv data filter
... add a test somewhere

src/wallet/rpcwallet.cpp Outdated
@@ -2602,6 +2603,7 @@ static const CRPCCommand commands[] =
{ "wallet", "addwitnessaddress", &addwitnessaddress, true, {"address"} },
{ "wallet", "backupwallet", &backupwallet, true, {"destination"} },
{ "wallet", "dumpprivkey", &dumpprivkey, true, {"address"} },
{ "wallet", "dumpmasterprivkey", &dumpmasterprivkey, true, {} },

This comment has been minimized.

Copy link
@jonasschnelli

jonasschnelli Jan 11, 2017

Member

nit: column alignment.

src/wallet/rpcdump.cpp Outdated

EnsureWalletIsUnlocked();

CKeyID masterKeyID = pwalletMain->GetHDChain().masterKeyID;

This comment has been minimized.

Copy link
@jonasschnelli

jonasschnelli Jan 11, 2017

Member

Use CWallet::IsHDEnabled()?

This comment has been minimized.

Copy link
@jonasschnelli

jonasschnelli Jan 11, 2017

Member

Well,... you need the masterKeys CKeyID anyway,... but I guess it would still make sense to use CWallet::IsHDEnabled()

@achow101
Copy link
Member Author

achow101 commented Jan 11, 2017

@jonasschnelli there is no sensitive data filter for the dump* commands. The user is not entering sensitive data, only sensitive data being output.

@achow101 achow101 force-pushed the achow101:dumpmasterprivkey branch Jan 11, 2017
@achow101
Copy link
Member Author

achow101 commented Jan 11, 2017

Addressed nits and added a test.

It may need more tests, but I'm not sure what actually needs to be tested.

@achow101 achow101 force-pushed the achow101:dumpmasterprivkey branch to 342a564 Jan 11, 2017
@jonasschnelli
Copy link
Member

jonasschnelli commented Jan 11, 2017

@jonasschnelli there is no sensitive data filter for the dump* commands. The user is not entering sensitive data, only sensitive data being output.

Argh. Right. I was confusing the sensitiv history filter with the idea of having a filter that disables certain sensitive commands.

@achow101 achow101 force-pushed the achow101:dumpmasterprivkey branch 2 times, most recently Aug 15, 2017
RPC command to export the master private key from a wallet.
@achow101 achow101 force-pushed the achow101:dumpmasterprivkey branch to 07fc811 Aug 17, 2017
@achow101
Copy link
Member Author

achow101 commented Feb 8, 2018

Closing this for now

@achow101 achow101 closed this Feb 8, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants
You can’t perform that action at this time.