Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.Sign up
GitHub is where the world builds software
Millions of developers and companies build, ship, and maintain their software on GitHub — the largest and most advanced development platform in the world.
[Qt] Add checkbox in the GUI to opt-in to RBF when creating a transaction #9592
Add signalRbf option to CCoinControl as suggested by Luke Dashjr <firstname.lastname@example.org> in bitcoin#9592 (comment)
Set signalRbf via CCoinControl as suggested by Luke Dashjr <email@example.com> in bitcoin#9592 (comment)
s/Allow/Request/ as suggested by Luke Dashjr <firstname.lastname@example.org> in bitcoin#9592 (comment)
Change RBF tooltip as suggested by Luke Dashjr <email@example.com> in bitcoin#9592 (comment)
Update RBF status line with comments in bitcoin#9592 (comment)
Access fWalletRbf global through WalletModel as suggested by Jonas Schnelli <firstname.lastname@example.org> in bitcoin#9592 (comment)
Tested ACK 92b9ff6.
Possible follow-up work:
I'm wondering whether it would make more sense to put the RBF checkbox next to the fee options instead. That would definitely avoid the layout issue with "verbose" languages like German or Spanish.
Think about it. We all know that RBF allows replacing transaction A with transaction B as long as A has no confirmations yet and B includes a higher fee. Nevertheless, as far as I know, the intended use case for RBF in Core is only to allow the user to increase the fee afterwards from the transactions history view by right-clicking, pressing "Increase fee..." and selecting a higher fee.
My point is that the user will not perceive the transaction being replaced but rather being "upgraded". That's why I believe that from an UX point of view, RBF is more related to fees than to a transaction as a whole, and therefore putting the checkbox in the fees frame makes much more sense to me.
Now the labels misses some bottom margin.
This should fix it:
diff --git a/src/qt/forms/sendcoinsdialog.ui b/src/qt/forms/sendcoinsdialog.ui index a633478..e25fe05 100644 --- a/src/qt/forms/sendcoinsdialog.ui +++ b/src/qt/forms/sendcoinsdialog.ui @@ -1178,8 +1178,8 @@ </property> <property name="sizeHint" stdset="0"> <size> - <width>800</width> - <height>1</height> + <width>40</width> + <height>5</height> </size> </property> </spacer>
Increase spacing below RBF checkbox as suggested bitcoin#9592 (comment)
Before this commit, the checkbox would always start off unchecked. After this commit it will respect the -walletrbf setting (which is currently false by default).
…ing a transaction c4e4792 [Qt] Change RBF checkbox to reflect -walletrbf setting (Russell Yanofsky) 838a58e [Qt] Add simple optin-RBF checkbox and confirmation info (Jonas Schnelli) 568c05a Allow to opt-into RBF when creating a transaction (Jonas Schnelli) Tree-SHA512: 3d52dcd4e44da8aed4d631748074afef78d38c860f2a8b95323f4801a989d6599a3498a753fc10daba4098c527ef5a0eb942e5b3f1bfd656e1a6bd272b8e6c57