New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove coin age priority and free transactions - implementation #9602
Changes from 1 commit
ddf58c7
12839cd
272b25a
400b151
fe282ac
ad727f4
f838005
0315888
49be7e1
f9b9371
359e8a0
7d4e950
b421e6d
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -263,11 +263,7 @@ void BlockAssembler::AddToBlock(CTxMemPool::txiter iter) | |
|
||
bool fPrintPriority = GetBoolArg("-printpriority", DEFAULT_PRINTPRIORITY); | ||
if (fPrintPriority) { | ||
double dPriority = iter->GetPriority(nHeight); | ||
CAmount dummy; | ||
mempool.ApplyDeltas(iter->GetTx().GetHash(), dPriority, dummy); | ||
LogPrintf("priority %.1f fee %s txid %s\n", | ||
dPriority, | ||
LogPrintf("fee %s txid %s\n", | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. nit: if we're changing this anyway how about we switch "fee" -> "feerate"? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. meh. It's pretty obvious that this is feerate from context:
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. changed anyway |
||
CFeeRate(iter->GetModifiedFee(), iter->GetTxSize()).ToString(), | ||
iter->GetTx().GetHash().ToString()); | ||
} | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm fine with backwards compatibility for a while but can we start to move to a better option name for this feature, and log that the old name is deprecated?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Agree with @sdaftuar . Commit at jnewbery@b83daf9 adds
-printfee
option. Feel free to pull into this PR if you want it, or I'll open another PR after this gets merged.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I always interpreted this as print the priority as in the sort order for mining. I have no problem changing it, but I'll leave that for another PR if people want it.