Fix typo and spelling inconsistency in CONTRIBUTING.md #9675
Conversation
|
NACK. I am the original author and I deliberately used English spelling. |
|
@btcdrak Thanks for your comment. In such case, we don't need to change "modularisation" and "behaviour", but we have to change another "behavior", don't we? |
|
We allow both variants of English to be used. Even in the same file. |
|
That's somewhat inconsistent, but I perfectly understand the reasoning behind it. The only valid change is 'GitHub'? If the author is planning on doing more of these, then they should probably combine them. |
|
Thanks for discussion about this. |
|
Looks good d788f38 👍 |
|
ACK, could you squash? |
doc/translation_process.md
Outdated
There was a problem hiding this comment.
There is a second instance of Github in this file, please fix it too (https://github.com/bitcoin/bitcoin/pull/9675/files#diff-eb26390875720fc65e1c6c74a87626ffR35).
There was a problem hiding this comment.
@paveljanik Thanks for letting me know! I fixed it too.
|
Fix one more GitHub spelling. |
|
Please squash your commits according to https://github.com/bitcoin/bitcoin/blob/master/CONTRIBUTING.md#squashing-commits |
Fix spellings of GitHub Remove unnecessary changes Fix GitHub spelling on doc/translation_process.md
kokifpen
force-pushed
the
fix_typo_in_contributing
branch
from
6906481 to
36164fa
Compare
|
@MarcoFalke Done. Thanks for notifying me about squashing. |
|
ACK 36164fa |
36164fa Fix typo and spelling inconsistency in CONTRIBUTING.md (Koki Takahashi)
…NG.md 36164fa Fix typo and spelling inconsistency in CONTRIBUTING.md (Koki Takahashi)
…NG.md 36164fa Fix typo and spelling inconsistency in CONTRIBUTING.md (Koki Takahashi)
…NG.md 36164fa Fix typo and spelling inconsistency in CONTRIBUTING.md (Koki Takahashi)
7 participants
Fix some typo and spelling inconsistency in CONTRIBUTING.md.
behaviourandbehaviormodularisationtomodularizationGitHub