Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.Sign up
Harden against mistakes handling invalid blocks #9765
Fixes a bug in AcceptBlock() in invoking CheckBlock() with incorrect
Updates the (overspecified) tests to match the slight behavior change (different reject code).
Bitfields/Enumerations instead of bool, bool, bool, ... also tends to help make code like this more readable and thus reviewable. Multiple boolean parameters to a function make code hard to understand, always have to look at the signature to find out which one is what.