New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update nMinimumChainWork and defaultAssumeValid. #9779

Merged
merged 1 commit into from Feb 17, 2017

Conversation

Projects
None yet
8 participants
@gmaxwell
Copy link
Member

gmaxwell commented Feb 16, 2017

No description provided.

@petertodd

This comment has been minimized.

Copy link
Contributor

petertodd commented Feb 16, 2017

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA256

utACK 3f78e460ba980d38149ee50ff5dfd75741aad9f2

I believe 0000000000000000000000000000000000000000003f94d1ad391682fe038bf5 to a valid Bitcoin blockchain.

-----BEGIN PGP SIGNATURE-----

iQEcBAEBCAAGBQJYpgDFAAoJECSBQD2l8JH7xgEH/2n5BSrLNBkUrZthOeBYdXa+
ntmjRzhZaMmlRgCTVnVJR0PN8e3FHEhdeWz+LxAwAlefOTehGqlqjxmaI1VQnqGq
8a3LLvmZdQ5WD5fN4wGA4wDU1DjRPdG0k8O0W/p9BK/ABMgWiV0wyx1pDXvvn6V/
I9r8CGNlxUd1VqT9x6T3rxSkEZIPZcYWkVSEfp930348Dz6W7wC9qFKw8+pZ95h0
YVX/KUgFmq2+5ufuzBCW9irzwC1QrEcp1DO3Lg2myjYqqHJ2Z4wKN+zA2tNUpB+d
8NxVbqBdyKdD0SbJMYYOV3byJwPBiiejZzFZgp5fu3obEOSS0JA8r+dMxLrxUl4=
=Jkyt
-----END PGP SIGNATURE-----
@jtimon

This comment has been minimized.

Copy link
Member

jtimon commented Feb 16, 2017

utACK 3f78e46 for mainnet.
For testnet, getblock "0x00000000000128796ee387cf110ccb9d2f36cffaf7f73079c995377c65ac0dcc" tells me that the minimum chain work should be 0x00000000000000000000000000000000000000000000001dcfc5dbe39283e519 instead of 0x00000000000000000000000000000000000000000000001f057509eba81aed91

@MarcoFalke

This comment has been minimized.

Copy link
Member

MarcoFalke commented Feb 16, 2017

@jtimon

This comment has been minimized.

Copy link
Member

jtimon commented Feb 16, 2017

Right, but any reason for not having them matching? EDIT: (specially when you're updating both)

@MarcoFalke

This comment has been minimized.

Copy link
Member

MarcoFalke commented Feb 16, 2017

@fanquake fanquake added the Validation label Feb 17, 2017

@gmaxwell

This comment has been minimized.

Copy link
Member Author

gmaxwell commented Feb 17, 2017

@jtimon we only set the assumevalid back because the chain might reorg. But even if the chain reorgs the work will be strictly equal or better. So the chainwork should be set as far forward as possible, but assumevalid may need to be set back to avoid reorgs. (I submitted this PR only after looking to see that there was no visible fork at the bitcoin height there and checked that the block was a couple minutes old at least, otherwise I would have set it one block back-- but I still would have had chainwork at the highest point currently available)

And yes, as Marco says: we could even set minimum chain work into the future (except for the fact that doing so might confuse testing!)

@sipa sipa added this to the 0.14.0 milestone Feb 17, 2017

@laanwj laanwj merged commit 3f78e46 into bitcoin:master Feb 17, 2017

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

laanwj added a commit that referenced this pull request Feb 17, 2017

Merge #9779: Update nMinimumChainWork and defaultAssumeValid.
3f78e46 Update nMinimumChainWork and defaultAssumeValid. (Gregory Maxwell)
@MarcoFalke

This comment has been minimized.

Copy link
Member

MarcoFalke commented Feb 18, 2017

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA512

Post merge utACK 3f78e460ba980d38149ee50ff5dfd75741aad9f
-----BEGIN PGP SIGNATURE-----

iQEcBAEBCgAGBQJYp58IAAoJEC1/I3LlD+E3lnMH/RYgl3ENy05TRDGxY8PMVkav
NVGIQCqgrsffHBQw62bCH66gSxpPnBLf5bOw8ZYhiHaiCMgw3ODx9DTc5GL/2v0V
m4F/Sr9PW4GQUKzVxTYZTGL+HkwYHplUtPr5yc9++pP8PkXHy/JzVp+4I6IwYAOr
qXEmGLrbNUfzvaUe9I+0SZYD/H+lFifg3b2FmX/i0hXJZMSqJ9sBQjCyHLGMBqU5
Do0eHAlp5kxtq0Dc4I+dzF22P5mOZ11xS6AtWUcD0o4MKQOq+1/gYh62jnWBuxHE
YbtVYaBg0gFZBFNLP8u4vi4LHbFPs6+DLuCQnO3ehXOcgOyOTMooZCFyxyF2Y08=
=eIBQ
-----END PGP SIGNATURE-----
@sdaftuar
Copy link
Member

sdaftuar left a comment

post-merge ACK


// By default assume that the signatures in ancestors of this block are valid.
consensus.defaultAssumeValid = uint256S("0x0000000000000000030abc968e1bd635736e880b946085c93152969b9a81a6e2"); //447235
consensus.defaultAssumeValid = uint256S("0x00000000000000000013176bf8d7dfeab4e1db31dc93bc311b436e82ab226b90"); //453354

This comment has been minimized.

@sdaftuar

sdaftuar Feb 27, 2017

Member

ACK 0x00000000000000000013176bf8d7dfeab4e1db31dc93bc311b436e82ab226b90


// By default assume that the signatures in ancestors of this block are valid.
consensus.defaultAssumeValid = uint256S("0x000000000871ee6842d3648317ccc8a435eb8cc3c2429aee94faff9ba26b05a0"); //1043841
consensus.defaultAssumeValid = uint256S("0x00000000000128796ee387cf110ccb9d2f36cffaf7f73079c995377c65ac0dcc"); //1079274

This comment has been minimized.

@sdaftuar

sdaftuar Feb 27, 2017

Member

ACK 0x00000000000128796ee387cf110ccb9d2f36cffaf7f73079c995377c65ac0dcc

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment