Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid VLA in hash.h #9791

Merged
merged 1 commit into from Feb 19, 2017

Conversation

@sipa
Copy link
Member

commented Feb 17, 2017

No description provided.

@gmaxwell
Copy link
Contributor

left a comment

utACK.

@fanquake fanquake added the Validation label Feb 18, 2017

@paveljanik

This comment has been minimized.

Copy link
Contributor

commented Feb 18, 2017

Compiles and works together with #9789.

ACK 5c8fd50

@laanwj

This comment has been minimized.

Copy link
Member

commented Feb 18, 2017

utACK 5c8fd50

@sipa

This comment has been minimized.

Copy link
Member Author

commented Feb 18, 2017

To clarify: my GCC does not consider this to be a VLA, but at least some Clang versions do.

@laanwj

This comment has been minimized.

Copy link
Member

commented Feb 18, 2017

Well I think this makes the code clearer too, so it's a win in any case.

@MarcoFalke

This comment has been minimized.

Copy link
Member

commented Feb 18, 2017

5c8fd50 gives same binaries with recent gcc on my arch.

utACK 5c8fd50

@laanwj laanwj merged commit 5c8fd50 into bitcoin:master Feb 19, 2017

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
laanwj added a commit that referenced this pull request Feb 19, 2017
Merge #9791: Avoid VLA in hash.h
5c8fd50 Avoid VLA in hash.h (Pieter Wuille)
laanwj added a commit that referenced this pull request Feb 28, 2017
Avoid VLA in hash.h
Github-Pull: #9791
Rebased-From: 5c8fd50
codablock added a commit to codablock/dash that referenced this pull request Jan 26, 2018
Merge bitcoin#9791: Avoid VLA in hash.h
5c8fd50 Avoid VLA in hash.h (Pieter Wuille)
andvgal added a commit to energicryptocurrency/energi that referenced this pull request Jan 6, 2019
Merge bitcoin#9791: Avoid VLA in hash.h
5c8fd50 Avoid VLA in hash.h (Pieter Wuille)
CryptoCentric added a commit to absolute-community/absolute that referenced this pull request Feb 27, 2019
Merge bitcoin#9791: Avoid VLA in hash.h
5c8fd50 Avoid VLA in hash.h (Pieter Wuille)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
6 participants
You can’t perform that action at this time.