Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Trivial: fix comments referencing AppInit2 #9833

merged 1 commit into from Feb 24, 2017
Changes from all commits
File filter...
Filter file types
Jump to…
Jump to file or symbol
Failed to load files and symbols.


Just for now

@@ -118,10 +118,6 @@ static const char* FEE_ESTIMATES_FILENAME="fee_estimates.dat";
// threads that should only be stopped after the main network-processing
// threads have exited.
// Note that if running -daemon the parent process returns from AppInit2
// before adding any threads to the threadGroup, so .join_all() returns
// immediately and the parent exits from main().
// Shutdown for Qt is very similar, only it uses a QTimer to detect
// fRequestShutdown getting set, and then does the normal Qt
// shutdown thing.
@@ -188,7 +184,7 @@ void Shutdown()
if (!lockShutdown)

/// Note: Shutdown() must be able to handle cases in which AppInit2() failed part of the way,
/// Note: Shutdown() must be able to handle cases in which initialization failed part of the way,
/// for example if the data directory was found to be locked.
/// Be sure that anything that writes files or flushes caches only does this if the respective
/// module was initialized.
@@ -268,7 +268,7 @@ void BitcoinCore::initialize()
qDebug() << __func__ << ": Running AppInit2 in thread";
qDebug() << __func__ << ": Running initialization in thread";
if (!AppInitBasicSetup())
Q_EMIT initializeResult(false);
@@ -457,7 +457,7 @@ void BitcoinApplication::initializeResult(int retval)
returnValue = retval ? 0 : 1;
// Log this only after AppInit2 finishes, as then logging setup is guaranteed complete
// Log this only after AppInitMain finishes, as then logging setup is guaranteed complete
qWarning() << "Platform customization:" << platformStyle->getName();
@@ -90,7 +90,8 @@ class CSignatureCache
static CSignatureCache signatureCache;

// To be called once in AppInit2/TestingSetup to initialize the signatureCache
// To be called once in AppInitMain/BasicTestingSetup to initialize the
// signatureCache.
void InitSignatureCache()
// nMaxCacheSize is unsigned. If -maxsigcachesize is set to zero,
ProTip! Use n and p to navigate between commits in a pull request.
You can’t perform that action at this time.