Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[QT] Show more descriptive label for pay to yourself entries #9985

Closed
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
6 participants
@NicolasDorier
Copy link
Member

NicolasDorier commented Mar 13, 2017

This show a more descriptive label for Pay To Yourself transaction entries in bitcoin QT. Showing the label of the first Output.

Before:
before

After:
after

Pay to yourself is common when using Bitcoin Core for tracking coins going from and to Watch-Only addresses. For example, in the case of TumblerBit, it will make it easier to see when a coins is transitioning throught different states: Wallet =>Alice Escrow => Alice Offer => Alice Offer Redeem.

@NicolasDorier NicolasDorier force-pushed the NicolasDorier:watchonlylabel branch to bbfdb8d Mar 13, 2017

@fanquake fanquake added the GUI label Mar 14, 2017

@laanwj

This comment has been minimized.

Copy link
Member

laanwj commented Mar 14, 2017

Concept ACK

parts.append(TransactionRecord(hash, nTime, TransactionRecord::SendToSelf, "",
std::string address;
CTxDestination destAddress;
if (wtx.tx->vout.size() >= 1 && ExtractDestination(wtx.tx->vout[0].scriptPubKey, destAddress))

This comment has been minimized.

@jonasschnelli

jonasschnelli Mar 14, 2017

Member

This list only the first to-yourself-output. But I think this is okay.

@da2ce7

This comment has been minimized.

Copy link

da2ce7 commented Mar 15, 2017

For 'send to yourself' transactions, maybe the row-background shading should be tinted a different colour. So it is more visually apparent what transactions leave the wallet?

@luke-jr

This comment has been minimized.

Copy link
Member

luke-jr commented Mar 15, 2017

I think it may be a good idea to just remove send-to-self as a thing. In some cases (eg, CoinJoins), it is indistinguishable from send-to-someone-else + receive-from-someone-else in the same transaction...

@NicolasDorier

This comment has been minimized.

Copy link
Member Author

NicolasDorier commented Mar 15, 2017

@da2ce7 there is the left column that already have a logo to distinguish.
@luke-jr I think this is a good idea, will try that

@NicolasDorier

This comment has been minimized.

Copy link
Member Author

NicolasDorier commented Mar 15, 2017

@luke-jr an alternative would be to not consider watch-only as "self".

@luke-jr

This comment has been minimized.

Copy link
Member

luke-jr commented Mar 15, 2017

CoinJoins aren't necessarily watch-only.

@NicolasDorier

This comment has been minimized.

Copy link
Member Author

NicolasDorier commented Mar 16, 2017

I think #10007 is superior alternative.
Keeping open this one until it is clear we will not use it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.