Skip to content
Bitcoin Core integration/staging tree
Branch: master
Clone or download
fanquake Merge #16420: QA: Fix race condition in wallet_encryption test
024ecd7 QA: Fix race condition in wallet_encryption test (Jonas Schnelli)

Pull request description:

  There is some imprecision probably in the internal HTTPRPCTimer class (haven't exactly figured out where).
  But we can't expect that waiting excatly 2 seconds right after calling `walletpassphrase(2)` will result in a locked wallet due to the nature how we internally handle threads/timers.

  The wallet_encryption test fails regularely in CIs.

  Here is a logged session:
  ```shell
  �[0;34m node0 2019-07-18T18:51:22.569739Z [] ThreadRPCServer method=walletpassphrase user=__cookie__ �[0m
  �[0;34m node0 2019-07-18T18:51:22.628656Z [] queue run of timer lockwallet() in 2 seconds (using HTTP) �[0m
  �[0;34m node0 2019-07-18T18:51:22.629002Z [] Received a POST request for / from 127.0.0.1:46898 �[0m
  �[0;34m node0 2019-07-18T18:51:22.629081Z [] ThreadRPCServer method=dumpprivkey user=__cookie__ �[0m
  �[0;34m node0 2019-07-18T18:51:24.445620Z [] Flushing wallet.dat �[0m
  �[0;34m node0 2019-07-18T18:51:24.451421Z [] Flushed wallet.dat 6ms �[0m
  �[0;34m node0 2019-07-18T18:51:24.631703Z [] Received a POST request for / from 127.0.0.1:46898 �[0m
  �[0;34m node0 2019-07-18T18:51:24.631737Z [] ThreadRPCServer method=dumpprivkey user=__cookie__ �[0m
  �[0;36m test  2019-07-18T18:51:24.632000Z TestFramework (ERROR): Assertion failed �[0m
  �[0;36m                                   Traceback (most recent call last):�[0m
  �[0;36m                                     File "/home/ubuntu/src/test/functional/test_framework/test_framework.py", line 193, in main�[0m
  �[0;36m                                       self.run_test()�[0m
  �[0;36m                                     File "/home/ubuntu/src/test/functional/wallet_encryption.py", line 53, in run_test�[0m
  �[0;36m                                       assert_raises_rpc_error(-13, "Please enter the wallet passphrase with walletpassphrase first", self.nodes[0].dumpprivkey, address)�[0m
  ```

ACKs for top commit:
  promag:
    ACK 024ecd7, simple fix, one second shouldn't hurt.
  MarcoFalke:
    ACK 024ecd7
  fanquake:
    ACK 024ecd7

Tree-SHA512: 0cda1b8969b084bb765d2b35e90a8611c565ee458a7be1f2dde675f8ddbd9b9e421514547a7683f836e2c996e0538eb66b8c5b935b5a81e9319fb2be27624374
Latest commit 89d7229 Jul 18, 2019
Permalink
Type Name Latest commit message Commit time
Failed to load latest commit information.
.github Get more info about GUI-related issue on Linux Dec 27, 2018
.travis Merge #14505: test: Add linter to make sure single parameter construc… Jul 8, 2019
.tx qt: Pre-0.18 split-off translations update Feb 4, 2019
build-aux/m4 [depends] boost: update to 1.70 May 3, 2019
build_msvc Merge #16267: bench: Benchmark blockToJSON Jul 8, 2019
contrib contrib: guix: Additional clarifications re: substitutes Jul 12, 2019
depends contrib: Add deterministic Guix builds. Jul 12, 2019
doc Merge #15891: test: Require standard txs in regtest by default Jul 16, 2019
share Merge #16291: gui: Stop translating PACKAGE_NAME Jul 8, 2019
src Merge #16379: Fix autostart filenames on Linux for testnet/regtest Jul 18, 2019
test QA: Fix race condition in wallet_encryption test Jul 18, 2019
.appveyor.yml [MSVC] Copy build output to src/ automatically after build Jul 1, 2019
.cirrus.yml ci: Run extended tests Jun 20, 2019
.gitattributes Separate protocol versioning from clientversion Oct 29, 2014
.gitignore [MSVC] Copy build output to src/ automatically after build Jul 1, 2019
.python-version .python-version: Specify full version 3.5.6 Mar 2, 2019
.style.yapf test: .style.yapf: Set column_limit=160 Mar 4, 2019
.travis.yml Merge #16338: test: Disable other targets when enable-fuzz is set Jul 10, 2019
CONTRIBUTING.md doc: Rework section on ACK Jun 13, 2019
COPYING [Trivial] Update license year range to 2019 Dec 31, 2018
INSTALL.md Update INSTALL landing redirection notice for build instructions. Oct 5, 2016
Makefile.am Failing functional tests stop lcov Jun 13, 2019
README.md doc: Remove travis badge from readme Jun 19, 2019
SECURITY.md doc: Remove explicit mention of version from SECURITY.md Jun 14, 2019
autogen.sh Enable ShellCheck rules Jul 4, 2019
configure.ac Merge #16338: test: Disable other targets when enable-fuzz is set Jul 10, 2019
libbitcoinconsensus.pc.in Unify package name to as few places as possible without major changes Dec 14, 2015

README.md

Bitcoin Core integration/staging tree

https://bitcoincore.org

What is Bitcoin?

Bitcoin is an experimental digital currency that enables instant payments to anyone, anywhere in the world. Bitcoin uses peer-to-peer technology to operate with no central authority: managing transactions and issuing money are carried out collectively by the network. Bitcoin Core is the name of open source software which enables the use of this currency.

For more information, as well as an immediately useable, binary version of the Bitcoin Core software, see https://bitcoincore.org/en/download/, or read the original whitepaper.

License

Bitcoin Core is released under the terms of the MIT license. See COPYING for more information or see https://opensource.org/licenses/MIT.

Development Process

The master branch is regularly built and tested, but is not guaranteed to be completely stable. Tags are created regularly to indicate new official, stable release versions of Bitcoin Core.

The contribution workflow is described in CONTRIBUTING.md and useful hints for developers can be found in doc/developer-notes.md.

Testing

Testing and code review is the bottleneck for development; we get more pull requests than we can review and test on short notice. Please be patient and help out by testing other people's pull requests, and remember this is a security-critical project where any mistake might cost people lots of money.

Automated Testing

Developers are strongly encouraged to write unit tests for new code, and to submit new unit tests for old code. Unit tests can be compiled and run (assuming they weren't disabled in configure) with: make check. Further details on running and extending unit tests can be found in /src/test/README.md.

There are also regression and integration tests, written in Python, that are run automatically on the build server. These tests can be run (if the test dependencies are installed) with: test/functional/test_runner.py

The Travis CI system makes sure that every pull request is built for Windows, Linux, and macOS, and that unit/sanity tests are run automatically.

Manual Quality Assurance (QA) Testing

Changes should be tested by somebody other than the developer who wrote the code. This is especially important for large or high-risk changes. It is useful to add a test plan to the pull request description if testing the changes is not straightforward.

Translations

Changes to translations as well as new translations can be submitted to Bitcoin Core's Transifex page.

Translations are periodically pulled from Transifex and merged into the git repository. See the translation process for details on how this works.

Important: We do not accept translation changes as GitHub pull requests because the next pull from Transifex would automatically overwrite them again.

Translators should also subscribe to the mailing list.

You can’t perform that action at this time.